From patchwork Fri Oct 24 11:47:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiong Wang X-Patchwork-Id: 402822 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5B80414007D for ; Fri, 24 Oct 2014 22:47:24 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; q= dns; s=default; b=jbVu3m5MWGbzj75rLogOQ4ps6M2B4Ie0hKakIJfVGWu0Ej PIyr3r8RyfRBFoTb8MXIZR/FU56c7tK9aBez4sEsuX56DHKcUgSJGR/cN/yNb4nr gJ3fL3YWRbpPhQSbbYie+dEO68t1sMAyH1+hsS6n5hnkcRqojCJ0n2EJ8ANCc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; s= default; bh=zpyLRfCtQ3CCHUjq7qACgVOn6Ko=; b=FjQSBjj6ToSlsJ2lMy2C PzLYiiRQHJgYdBJMnUz+myv63aP6dPSmp4BqMS5fKnkmWP4Ln4Km5tD1wa7Mqqwc 1M99o2u412T7KGw0JdF8tr40OE9653+Fz4WtOIrj1BICI6KRrHOnq9f3EcJcufVi 7+DdC0yzzBun/88rh6Gf7tc= Received: (qmail 13350 invoked by alias); 24 Oct 2014 11:47:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13339 invoked by uid 89); 24 Oct 2014 11:47:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: service87.mimecast.com Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Oct 2014 11:47:15 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Fri, 24 Oct 2014 12:47:13 +0100 Received: from [10.1.205.157] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 24 Oct 2014 12:47:10 +0100 Message-ID: <544A3C3D.5070308@arm.com> Date: Fri, 24 Oct 2014 12:47:09 +0100 From: Jiong Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" Subject: [PATCH][ARM] revert changes on check_effective_target_arm_*_ok X-MC-Unique: 114102412471302201 X-IsSubscribed: yes we should not add explicit declaration there. arm_neon.h contains those prototype already. they will be available if the compiler configuration is with related builtin predefine, for example __ARM_FEATURE_CRYPTO. so, actually, if there is any warning when compile these test programs, they are expected, and we rely on these warnings to check whether certain features are available. previously, I only verified on arm-none-linux-gnueabi cross check, so have not exposed these regressions. no verified on arm-none-linux-gnueabihf, regression gone away on arm directory. make check RUNTESTFLAGS="aapcs.exp neon.exp acle.exp simd.exp arm.exp" ok for trunk? gcc/testsuite/ * lib/target-supports.exp (check_effective_target_arm_crypto_ok_nocache): Remove declaration for vaeseq_u8. (check_effective_target_arm_neon_fp16_ok_nocache): Remove declaration for vcvt_f16_f32. (check_effective_target_arm_neonv2_ok_nocache): Remove declaration for vfma_f32. diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 91460c2..4398345 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -2404,7 +2404,6 @@ proc check_effective_target_arm_crypto_ok_nocache { } { foreach flags {"" "-mfloat-abi=softfp" "-mfpu=crypto-neon-fp-armv8" "-mfpu=crypto-neon-fp-armv8 -mfloat-abi=softfp"} { if { [check_no_compiler_messages_nocache arm_crypto_ok object { #include "arm_neon.h" - extern uint8x16_t vaeseq_u8 (uint8x16_t, uint8x16_t); uint8x16_t foo (uint8x16_t a, uint8x16_t b) { @@ -2549,7 +2548,6 @@ proc check_effective_target_arm_neon_fp16_ok_nocache { } { "-mfpu=neon-fp16 -mfloat-abi=softfp"} { if { [check_no_compiler_messages_nocache arm_neon_fp_16_ok object { #include "arm_neon.h" - extern float16x4_t vcvt_f16_f32 (float32x4_t); float16x4_t foo (float32x4_t arg) { @@ -2625,7 +2623,6 @@ proc check_effective_target_arm_neonv2_ok_nocache { } { foreach flags {"" "-mfloat-abi=softfp" "-mfpu=neon-vfpv4" "-mfpu=neon-vfpv4 -mfloat-abi=softfp"} { if { [check_no_compiler_messages_nocache arm_neonv2_ok object { #include "arm_neon.h" - extern float32x2_t vfma_f32 (float32x2_t, float32x2_t, float32x2_t); float32x2_t foo (float32x2_t a, float32x2_t b, float32x2_t c) {