[testsuite] Fix gcc.dg/ipa/ipa-icf-2[18].c on Solaris

On 10/23/2014 11:38 AM, Jakub Jelinek wrote:
> On Thu, Oct 23, 2014 at 11:35:44AM +0200, Rainer Orth wrote:
>>> The testcase is clearly i?86/x86_64 specific, so it must be guarded with
>>> { target i?86-*-* x86_64-*-* }, and as it is a compile time test, no need
>>
>> Right, that's what my patch already does.
>>
>>> for assembler support, so just adding -msse2 option to dg-option is the
>>> right thing to do.
>>
>> Ok, will try that.  Still no idea why Linux/x86 and Solaris/x86 are
>> different here.
>
> Why do you think so?  I certainly have:
> FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors)
> UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-dump icf "Equal symbols: 1"
> UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-dump icf "Semantic equality hit:bar->foo"
> in my i686-linux test_summary log.  It really depends on how the compiler
> is configured, if it defaults to march that has sse/sse2 by default, it will
> succeed, otherwise it will not.
>
> 	Jakub
>

Hello.

I combined both patches and run regression tests on x86_64-linux-pc.
Ready for trunk?

Thanks,
Martin

On Thu, Oct 23, 2014 at 01:31:53PM +0200, Martin Liška wrote:
> On 10/23/2014 11:38 AM, Jakub Jelinek wrote:
> >On Thu, Oct 23, 2014 at 11:35:44AM +0200, Rainer Orth wrote:
> >>>The testcase is clearly i?86/x86_64 specific, so it must be guarded with
> >>>{ target i?86-*-* x86_64-*-* }, and as it is a compile time test, no need
> >>
> >>Right, that's what my patch already does.
> >>
> >>>for assembler support, so just adding -msse2 option to dg-option is the
> >>>right thing to do.
> >>
> >>Ok, will try that.  Still no idea why Linux/x86 and Solaris/x86 are
> >>different here.
> >
> >Why do you think so?  I certainly have:
> >FAIL: gcc.dg/ipa/ipa-icf-21.c (test for excess errors)
> >UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-dump icf "Equal symbols: 1"
> >UNRESOLVED: gcc.dg/ipa/ipa-icf-21.c scan-ipa-dump icf "Semantic equality hit:bar->foo"
> >in my i686-linux test_summary log.  It really depends on how the compiler
> >is configured, if it defaults to march that has sse/sse2 by default, it will
> >succeed, otherwise it will not.
> >
> >	Jakub
> >
> 
> Hello.
> 
> I combined both patches and run regression tests on x86_64-linux-pc.
> Ready for trunk?

With proper ChangeLog entry yes.

> diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-icf-21.c b/gcc/testsuite/gcc.dg/ipa/ipa-icf-21.c
> index 7358e43..68aabc5 100644
> --- a/gcc/testsuite/gcc.dg/ipa/ipa-icf-21.c
> +++ b/gcc/testsuite/gcc.dg/ipa/ipa-icf-21.c
> @@ -1,5 +1,5 @@
> -/* { dg-do compile } */
> -/* { dg-options "-O2 -fdump-ipa-icf"  } */
> +/* { dg-do compile { target i?86-*-* x86_64-*-* } } */
> +/* { dg-options "-O2 -msse2 -fdump-ipa-icf"  } */
>  
>  #include <xmmintrin.h>
>  
> diff --git a/gcc/testsuite/gcc.dg/ipa/ipa-icf-28.c b/gcc/testsuite/gcc.dg/ipa/ipa-icf-28.c
> index 538e0ab..bcaf84e 100644
> --- a/gcc/testsuite/gcc.dg/ipa/ipa-icf-28.c
> +++ b/gcc/testsuite/gcc.dg/ipa/ipa-icf-28.c
> @@ -1,4 +1,4 @@
> -/* { dg-do compile } */
> +/* { dg-do compile { target init_priority } } */
>  /* { dg-options "-O2 -fdump-ipa-icf-details -fno-inline"  } */
>  
>  __attribute__ ((noinline, constructor(200)))


	Jakub

On Thu, Oct 23, 2014 at 01:33:18PM +0200, Jakub Jelinek wrote:
> > I combined both patches and run regression tests on x86_64-linux-pc.
> > Ready for trunk?
> 
> With proper ChangeLog entry yes.

Actually, Rainer seems to have committed everything already.

	Jakub