From patchwork Mon Sep 15 10:56:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 389260 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 81B8D140142 for ; Mon, 15 Sep 2014 20:56:23 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; q=dns; s=default; b=X4ZtTWExgqUqtzmmd /8tIPFEpmRrRGARkAr8qpARIUn1SCvLRpqaKBNGB3GiGcBPLZyUEf/YEOTsm1PCt W6n5RWi3W5z22PSiSEdXTfG0qQk5H0RhCufJVOmPRerSDuhRq7pFsI/xAvM/ZNwX dw/4pNl2OweRqHfOnoeCxShpoY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:references :in-reply-to:content-type; s=default; bh=52/v/I5X/mrgY6uTEtrZcCd vYqg=; b=rJUq9IJW7/Svk7BOBO/dCQybCJvCA/n2qgBtlcoxRSTxBN6jKyhr+Pr 1bKBwJrPMTQpp8mPgxnoQyKAD0NtY+x1aGsGHeizDSBIaVLonjpb2unDegwha05J 4zaKyDr5Vb5WV2EShMsnBTUV3gvML95R1M7Xl9/H8aZ6TcW/Gx9s= Received: (qmail 3502 invoked by alias); 15 Sep 2014 10:56:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 3482 invoked by uid 89); 15 Sep 2014 10:56:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Sep 2014 10:56:12 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XTTx2-0000wK-FZ from Andrew_Stubbs@mentor.com ; Mon, 15 Sep 2014 03:56:08 -0700 Received: from [172.30.88.97] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.181.6; Mon, 15 Sep 2014 11:56:06 +0100 Message-ID: <5416C5C3.8070603@codesourcery.com> Date: Mon, 15 Sep 2014 11:56:03 +0100 From: Andrew Stubbs User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Richard Earnshaw , "gcc-patches@gcc.gnu.org" Subject: Re: [arm][patch] fix arm_neon_ok check on !arm_arch7 References: <5414B99D.3020202@codesourcery.com> <5416B580.9070208@arm.com> In-Reply-To: <5416B580.9070208@arm.com> On 15/09/14 10:46, Richard Earnshaw wrote: > Hmm, I wonder if arm_override_options should reject neon + (arch < 7). Is this more to your taste? Andrew P.S. arm_override_options was renamed in 2010. 2014-09-15 Andrew Stubbs * gcc/config/arm/arm.c (arm_option_override): Reject -mfpu=neon when architecture is older than ARMv7. Index: gcc/config/arm/arm.c =================================================================== --- gcc/config/arm/arm.c (revision 215228) +++ gcc/config/arm/arm.c (working copy) @@ -2845,6 +2845,9 @@ arm_fpu_desc = &all_fpus[arm_fpu_index]; + if (TARGET_NEON && !arm_arch7) + error ("target CPU does not support NEON"); + switch (arm_fpu_desc->model) { case ARM_FP_MODEL_VFP: