[RFC] RL78 - clean-up of missing operand mode warnings.

Hi,

This patch cleans up some warnings when building due to missing operand 
modes.

"trampoline_init" in rl78.md still produces warnings but I'm not 
entirely sure about how best to fix that insn and I didn't want to break 
anything.

Regards,

Richard


2014-04-15  Richard Hulme  <peper03@yahoo.com>

	* config/rl78/rl78.md (addsi3, addsi3_internal_virt,
	addsi3_internal_real, subsi3, subsi3_internal_virt,
	subsi3_internal_real): Add missing modes to operands.
	* config/rl78/rl78-real.md (*movqi_real, *xorqi3_real): Likewise.
	* config/rl78/rl78-virt.md (*movqi_virt, *xorqi3_vidr): Likewise.

---
  gcc/config/rl78/rl78-real.md |    4 ++--
  gcc/config/rl78/rl78-virt.md |    4 ++--
  gcc/config/rl78/rl78.md      |   12 ++++++------
  3 files changed, 10 insertions(+), 10 deletions(-)

operands[2]));
@@ -218,7 +218,7 @@
  (define_insn "addsi3_internal_virt"
    [(set (match_operand:SI          0 "nonimmediate_operand" "=v,&vm, vm")
  	(plus:SI (match_operand:SI 1 "general_operand"      "0, vim, vim")
-		 (match_operand    2 "general_operand"      "vim,vim,vim")))
+		 (match_operand:SI 2 "general_operand"      "vim,vim,vim")))
     (clobber (reg:HI AX_REG))
     (clobber (reg:HI BC_REG))
     ]
@@ -230,7 +230,7 @@
  (define_insn "addsi3_internal_real"
    [(set (match_operand:SI          0 "nonimmediate_operand" "=v,&vU, vU")
  	(plus:SI (match_operand:SI 1 "general_operand"      "+0, viU, viU")
-		 (match_operand    2 "general_operand" 
"viWabWhlWh1,viWabWhlWh1,viWabWhlWh1")))
+		 (match_operand:SI 2 "general_operand" 
"viWabWhlWh1,viWabWhlWh1,viWabWhlWh1")))
     (clobber (reg:HI AX_REG))
     (clobber (reg:HI BC_REG))
     ]
@@ -245,7 +245,7 @@
  (define_expand "subsi3"
    [(set (match_operand:SI           0 "nonimmediate_operand" "=&vm")
  	(minus:SI (match_operand:SI 1 "general_operand"      "vim")
-		  (match_operand    2 "general_operand"    "vim")))
+		  (match_operand:SI 2 "general_operand"    "vim")))
     ]
    ""
    "emit_insn (gen_subsi3_internal_virt (operands[0], operands[1], 
operands[2]));
@@ -255,7 +255,7 @@
  (define_insn "subsi3_internal_virt"
    [(set (match_operand:SI           0 "nonimmediate_operand" "=v,&vm, vm")
  	(minus:SI (match_operand:SI 1 "general_operand"      "0, vim, vim")
-		  (match_operand    2 "general_operand"      "vim,vim,vim")))
+		  (match_operand:SI 2 "general_operand"      "vim,vim,vim")))
     (clobber (reg:HI AX_REG))
     (clobber (reg:HI BC_REG))
     ]
@@ -267,7 +267,7 @@
  (define_insn "subsi3_internal_real"
    [(set (match_operand:SI           0 "nonimmediate_operand" "=v,&vU, vU")
  	(minus:SI (match_operand:SI 1 "general_operand"      "+0, viU, viU")
-		  (match_operand    2 "general_operand" 
"viWabWhlWh1,viWabWhlWh1,viWabWhlWh1")))
+		  (match_operand:SI 2 "general_operand" 
"viWabWhlWh1,viWabWhlWh1,viWabWhlWh1")))
     (clobber (reg:HI AX_REG))
     (clobber (reg:HI BC_REG))
     ]

I typically leave the mode off when the operand accepts a CONST_INT as
I've had problems with patterns matching CONST_INTs otherwise, as
CONST_INT rtx's do not have a mode (or have VOIDmode).

(yes, I know gcc is supposed to accomodate that, but like I said, I've
had problems...)

On 15/04/14 22:58, DJ Delorie wrote:
> I typically leave the mode off when the operand accepts a CONST_INT as
> I've had problems with patterns matching CONST_INTs otherwise, as
> CONST_INT rtx's do not have a mode (or have VOIDmode).
>
> (yes, I know gcc is supposed to accomodate that, but like I said, I've
> had problems...)

Ok, that's fine.  I was just trying to mop up one little bit of the sea 
of warnings.

It seems a little inconsistent, however, that *movqi_real and 
*xorqi3_real don't specify modes but *movhi_real and 
*andqi_real/*iorqi_real do (and they also accept CONST_INTs).  Not that 
I'm advocating generating more warnings, but my inner OCD likes 
consistency :)

Richard.

> It seems a little inconsistent, however, that *movqi_real and 
> *xorqi3_real don't specify modes but *movhi_real and 
> *andqi_real/*iorqi_real do (and they also accept CONST_INTs).  Not that 
> I'm advocating generating more warnings, but my inner OCD likes 
> consistency :)

Adding the mode might be the right way, but I've seen cases where it
wasn't.  My paranoia supercedes my OCD ;-)