| Message ID | 532B0A32.5080506@oarcorp.com |
|---|---|
| State | New |
| Headers | show |
Hi Joel, > It took a while to find this but v850-rtems lost the include > paths for the rtems specific .h files in newlib due to > the line that resets tmake_file rather than appends to it. > > Is this OK to apply to all impacted branches and the head? > > 2014-03-20 Joel Sherrill <joel.sherrill@oarcorp.com> > > * config.host (v850*-*-*): Add to tmake_file instead of resetting > it. This was removing the v850*-*-rtems* settings. Omit the `This was removing...' part: no explanations in ChangeLogs. I believe this is your call as RTEMS maintainer, even this late in the 4.9 release cycle, since it cannot affect any other target. Rainer
On 3/20/2014 10:57 AM, Rainer Orth wrote: > Hi Joel, > >> It took a while to find this but v850-rtems lost the include >> paths for the rtems specific .h files in newlib due to >> the line that resets tmake_file rather than appends to it. >> >> Is this OK to apply to all impacted branches and the head? >> >> 2014-03-20 Joel Sherrill <joel.sherrill@oarcorp.com> >> >> * config.host (v850*-*-*): Add to tmake_file instead of resetting >> it. This was removing the v850*-*-rtems* settings. > Omit the `This was removing...' part: no explanations in ChangeLogs. > > I believe this is your call as RTEMS maintainer, even this late in the > 4.9 release cycle, since it cannot affect any other target. Done. This is a minor issue which results in the target being unbuildable. Also committed to 4.7 and 4.8. Thanks. > Rainer >
On 03/20/14 09:33, Joel Sherrill wrote: > Hi > > It took a while to find this but v850-rtems lost the include > paths for the rtems specific .h files in newlib due to > the line that resets tmake_file rather than appends to it. > > Is this OK to apply to all impacted branches and the head? > > 2014-03-20 Joel Sherrill <joel.sherrill@oarcorp.com> > > * config.host (v850*-*-*): Add to tmake_file instead of resetting > it. This was removing the v850*-*-rtems* settings. Yes. This is fine. jeff
diff --git a/libgcc/config.host b/libgcc/config.host index bdc725f..f8f74cc 100644 --- a/libgcc/config.host +++ b/libgcc/config.host @@ -1195,7 +1195,7 @@ tilepro*-*-linux*) md_unwind_header=tilepro/linux-unwind.h ;; v850*-*-*) - tmake_file="v850/t-v850 t-fdpbit" + tmake_file="${tmake_file} v850/t-v850 t-fdpbit" ;; vax-*-linux*) tmake_file="$tmake_file vax/t-linux"
Hi It took a while to find this but v850-rtems lost the include paths for the rtems specific .h files in newlib due to the line that resets tmake_file rather than appends to it. Is this OK to apply to all impacted branches and the head? 2014-03-20 Joel Sherrill <joel.sherrill@oarcorp.com> * config.host (v850*-*-*): Add to tmake_file instead of resetting it. This was removing the v850*-*-rtems* settings.