diff mbox

[PING,AARCH64] Resolves testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression

Message ID 530B15A3.6090206@arm.com
State New
Headers show

Commit Message

Renlin Li Feb. 24, 2014, 9:49 a.m. UTC 
On 03/02/14 10:02, Renlin Li wrote:
> On 02/02/14 19:02, Renlin Li wrote:
>> Hi all,
>>
>> This is a simple patch which resolves 
>> testsuite/gcc.target/aarch64/aapcs64/ret-func-1.c regression.
>>
>> Basically, no special operations are needed for vector type i32in128 
>> or f32in64 in big-endian mode any more due the aarch64 back-end change.
>>
>> Okay for trunk?
>>
>> Kind regards,
>> Renlin Li
>>
> Hi all,
>
> I forgot to attach the ChangeLog. Sorry for this additional annoying 
> email.
>
> Kind regards,
> Renlin Li
>
> gcc/testsuite/ChangeLog:
>
> 2014-02-03  Renlin Li  <Renlin.Li@arm.com>
>
>     * gcc.target/aarch64/aapcs64/validate_memory.h: move f32in64 and 
> i32in128 cases
>     outside special big-endian processing block.
Hi all,

Could anybody help me to review this patch?

Thank you!
Renlin Li

gcc/testsuite/ChangeLog:

2014-02-03  Renlin Li <Renlin.Li@arm.com>

     * gcc.target/aarch64/aapcs64/validate_memory.h: Move f32in64 and 
i32in128 cases
     outside special big-endian processing block.

Comments

Marcus Shawcroft Feb. 27, 2014, 12:33 p.m. UTC | #1 
On 24 February 2014 09:49, Renlin Li <renlin.li@arm.com> wrote:

> gcc/testsuite/ChangeLog:
>
> 2014-02-03  Renlin Li <Renlin.Li@arm.com>
>
>     * gcc.target/aarch64/aapcs64/validate_memory.h: Move f32in64 and
> i32in128 cases
>     outside special big-endian processing block.


This is is a fix for a broken test case, this is OK.

/Marcus
Kyrylo Tkachov March 3, 2014, 12:08 p.m. UTC | #2 
On 27/02/14 12:33, Marcus Shawcroft wrote:
> On 24 February 2014 09:49, Renlin Li <renlin.li@arm.com> wrote:
>
>> gcc/testsuite/ChangeLog:
>>
>> 2014-02-03  Renlin Li <Renlin.Li@arm.com>
>>
>>      * gcc.target/aarch64/aapcs64/validate_memory.h: Move f32in64 and
>> i32in128 cases
>>      outside special big-endian processing block.
>
> This is is a fix for a broken test case, this is OK.

Hi all,

I've committed this as r208275 with ChangeLog entry:

2014-03-03  Renlin Li  <Renlin.Li@arm.com>

     * gcc.target/aarch64/aapcs64/validate_memory.h: Move f32in64 and
     i32in128 cases outside special big-endian processing block.

> /Marcus
>
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h b/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
index ac94625..24431c6 100644
--- a/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
+++ b/gcc/testsuite/gcc.target/aarch64/aapcs64/validate_memory.h
@@ -60,8 +60,6 @@  validate_memory (void *mem1, char *mem2, size_t size, enum structure_type type)
     case i8in64:
     case i16in64:
     case i32in64:
-    case f32in64:
-    case i32in128:
       for (i = 0; i < size; i += element_size[type])
 	{
 	  if (memcmp (cmem1 + i,
@@ -72,6 +70,8 @@  validate_memory (void *mem1, char *mem2, size_t size, enum structure_type type)
       return 0;
       break;
 #endif
+    case f32in64:
+    case i32in128:
     default:
       break;
     }