| Message ID | 52CBFA27.5080208@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Jan 07, 2014 at 01:59:19PM +0100, Florian Weimer wrote: > gcc.target/i386/pr59099.c fails on x86_64-redhat-linux-gnu with > --disable-multilib because linking -m32 code is not supported. The > test case passes in 64-bit mode as well. The other -m32 tests do > not use dg-do run, so they do not exhibit this problem. > > Okay for trunk? No, this IMHO really should be: /* { dg-do run { target { ia32 && fpic } } } */ /* { dg-options "-O2 -fPIC" } */ All tests in gcc.target/i386 having -m32 (or -m64) in dg-options are buggy and should be fixed, either by adding { target ia32 } to their dg-do compile or whatever other dg-do they have, or adding /* { dg-require-effective-target ia32 } */ line and dropping the -m32 from dg-options. > 2014-01-07 Florian Weimer <fweimer@redhat.com> > > * gcc.target/i386/pr59099.c: Drop -m32. > > Index: gcc/testsuite/gcc.target/i386/pr59099.c > =================================================================== > --- gcc/testsuite/gcc.target/i386/pr59099.c (revision 206311) > +++ gcc/testsuite/gcc.target/i386/pr59099.c (working copy) > @@ -1,5 +1,5 @@ > /* { dg-do run } */ > -/* { dg-options "-O2 -fPIC -m32" } */ > +/* { dg-options "-O2 -fPIC" } */ > > void (*pfn)(void); Jakub
2014-01-07 Florian Weimer <fweimer@redhat.com> * gcc.target/i386/pr59099.c: Drop -m32. Index: gcc/testsuite/gcc.target/i386/pr59099.c =================================================================== --- gcc/testsuite/gcc.target/i386/pr59099.c (revision 206311) +++ gcc/testsuite/gcc.target/i386/pr59099.c (working copy) @@ -1,5 +1,5 @@ /* { dg-do run } */ -/* { dg-options "-O2 -fPIC -m32" } */ +/* { dg-options "-O2 -fPIC" } */ void (*pfn)(void);