diff mbox

PING: Fwd: Re: [patch] implement Cilk Plus simd loops on trunk

Message ID 528A2867.7020003@arm.com
State New
Headers show

Commit Message

Kyrylo Tkachov Nov. 18, 2013, 2:47 p.m. UTC 
On 16/11/13 01:20, Aldy Hernandez wrote:
> On 11/15/13 15:05, Aldy Hernandez wrote:
>>> Why all this, and not keep everything but
>>> GF_OMP_FOR_KIND_SIMD and GF_OMP_FOR_KIND_DISTRIBUTE
>>> as they were, and just use:
>>>      GF_OMP_FOR_KIND_DISTIRBUTE = 1 << 0,
>>>      GF_OMP_FOR_KIND_SIMD       = 2 << 0,
>>>      GF_OMP_FOR_KIND_CILKSIMD   = 3 << 0,
>> Sounds good.  Testing the following patch against my previous patch
>> which had already been committed.
>>
>> If there are no regressions, I will commit.
>>
>> Aldy
>>
> Committed.

Hi Aldy,

The testcase c-c++-common/cilk-plus/PS/body.c needs an effective target check 
for fopenmp before adding -fopenmp to its options, otherwise it'll fail on 
bare-metal targets like arm-none-eabi.

This patch adds that.

Ok to commit?

Thanks,
Kyrill

2013-11-18  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * c-c++-common/cilk-plus/PS/body.c: Add fopenmp effective target check.

Comments

Aldy Hernandez Nov. 18, 2013, 3:45 p.m. UTC | #1 
> The testcase c-c++-common/cilk-plus/PS/body.c needs an effective target
> check for fopenmp before adding -fopenmp to its options, otherwise it'll
> fail on bare-metal targets like arm-none-eabi.
>
> This patch adds that.
>
> Ok to commit?
>
> Thanks,
> Kyrill
>
> 2013-11-18  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>      * c-c++-common/cilk-plus/PS/body.c: Add fopenmp effective target check.

You can commit this as obvious.

Thanks.
diff mbox

Patch

diff --git a/gcc/testsuite/c-c++-common/cilk-plus/PS/body.c b/gcc/testsuite/c-c++-common/cilk-plus/PS/body.c
index 9b10041..82c0a0c 100644
--- a/gcc/testsuite/c-c++-common/cilk-plus/PS/body.c
+++ b/gcc/testsuite/c-c++-common/cilk-plus/PS/body.c
@@ -1,5 +1,6 @@ 
 /* { dg-do compile } */
 /* { dg-options "-fcilkplus -fopenmp" } */
+/* { dg-require-effective-target fopenmp } */
 
 int *a, *b, c;
 void *jmpbuf[10];