From patchwork Fri Apr 22 22:54:26 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 92589 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 77982B6F1C for ; Sat, 23 Apr 2011 08:54:52 +1000 (EST) Received: (qmail 11398 invoked by alias); 22 Apr 2011 22:54:50 -0000 Received: (qmail 11388 invoked by uid 22791); 22 Apr 2011 22:54:47 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Apr 2011 22:54:31 +0000 Received: from eggs.gnu.org ([140.186.70.92]:52052) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QDPF8-0005Zv-6P for gcc-patches@gnu.org; Fri, 22 Apr 2011 18:54:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QDPF6-0004UN-U7 for gcc-patches@gnu.org; Fri, 22 Apr 2011 18:54:29 -0400 Received: from qmta11.westchester.pa.mail.comcast.net ([76.96.59.211]:45906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QDPF6-0004UG-Q6 for gcc-patches@gnu.org; Fri, 22 Apr 2011 18:54:28 -0400 Received: from omta12.westchester.pa.mail.comcast.net ([76.96.62.44]) by QMTA11.westchester.pa.mail.comcast.net with comcast id amuU1g0090xGWP85BmuVyF; Fri, 22 Apr 2011 22:54:29 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta12.westchester.pa.mail.comcast.net with comcast id amuT1g00b0BKwT43YmuUH4; Fri, 22 Apr 2011 22:54:29 +0000 Subject: Re: (build) Patch to fix cp/cfns.gperf building issues Mime-Version: 1.0 (Apple Message framework v1084) From: Mike Stump In-Reply-To: <1303485121.088925951@www2.webmail.us> Date: Fri, 22 Apr 2011 15:54:26 -0700 Cc: "gcc-patches@gnu.org" Message-Id: <514AA7B6-0B41-42BD-B39B-71E9434E152D@comcast.net> References: <1303485121.088925951@www2.webmail.us> To: Nicola Pero X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.96.59.211 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Apr 22, 2011, at 8:12 AM, Nicola Pero wrote: > This patch fixes a building annoyance that I had when building on a new > machine (an x86_64 gnu/linux box). > > The building failed. It was down to two problems: > > * due to how I got a copy of the GCC source code on the machine, the timestamp > of each source file was the timestamp of when it was copied to the machine (ie, > a random timestamp from the point of view of the building system). This caused > the build system to decide that $(srcdir)/cp/cfns.h needed to be rebuilt from > $(srcdir)/cp/cfns.gperf (it didn't, obviously; the source code was trunk with > no changes). Additionally, contrib/gcc_update --touch can be used to to fix the time stamps until such time as someone changes the gperf rule to be under maintainer mode. So, only the dependency should go away under a maintainer rules, as in the below, not the entire rule. Ok? 2011-04-22 Mike Stump * Make-lang.in: Only run gperf in maintainer mode. Index: cp/Make-lang.in =================================================================== --- cp/Make-lang.in (revision 172670) +++ cp/Make-lang.in (working copy) @@ -105,7 +105,10 @@ cc1plus$(exeext): $(CXX_OBJS) cc1plus-ch $(CXX_OBJS) cc1plus-checksum.o $(BACKEND) $(LIBS) $(BACKENDLIBS) # Special build rules. +ifneq ($(MAINT),) $(srcdir)/cp/cfns.h: $(srcdir)/cp/cfns.gperf +endif +$(srcdir)/cp/cfns.h: gperf -o -C -E -k '1-6,$$' -j1 -D -N 'libc_name_p' -L ANSI-C \ $(srcdir)/cp/cfns.gperf > $(srcdir)/cp/cfns.h