From patchwork Wed Mar 6 15:34:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 225531 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A0C972C0380 for ; Thu, 7 Mar 2013 02:34:57 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1363188897; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=1pmmIuYGqbX5esRMrFVEH6CZ/A0=; b=DmgAPMWb+Vkm2yA rDBqPQ7SP9HgGPWin7I5CaNzhjtasFX9ZuEHOs/on2FPOtRGScbhp+e+czHXofyV 6QV7sldoQQ9vkyEaZfyv4nGxTRGXQF3kv86winpX81Jz5mqjwNr7yVgYtBkSxUQ9 SMYdxTqIdo4ZLI+JmfRJpELRSHCw= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=m3jsG/Cz5jPYBKCdTocldee1/Ypn4NWBh8tQ4K2JUpxm9TGkcocZlJauxpTx7G ca0FbrK0Yq3lFCibn83/pid1yIVD96RkjpCwT5wFBBVBw7c2Ebxv4DQH7tQwNTou YJZ3UYMghfp/u57owM0dADy4vFqGqOdBYKbL1EQS2stGw=; Received: (qmail 6287 invoked by alias); 6 Mar 2013 15:34:40 -0000 Received: (qmail 6212 invoked by uid 22791); 6 Mar 2013 15:34:38 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_SPAMHAUS_DROP, KHOP_THREADED, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Mar 2013 15:34:33 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r26FYSHB028311 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 6 Mar 2013 10:34:28 -0500 Received: from [10.3.113.140] (ovpn-113-140.phx2.redhat.com [10.3.113.140]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r26FYQ0X001149; Wed, 6 Mar 2013 10:34:27 -0500 Message-ID: <51376201.7090306@redhat.com> Date: Wed, 06 Mar 2013 10:34:25 -0500 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Rainer Orth CC: Jack Howarth , gcc-patches@gcc.gnu.org, jason@gcc.gnu.org Subject: Re: [PATCH] Fix g++.dg/debug/dwarf2/thunk1.C on darwin References: <20130305221945.GA3023@bromo.med.uc.edu> In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 03/06/2013 06:33 AM, Rainer Orth wrote: > Why not skip the whole test with dg-skip-if, since the scan is the whole > point of the testcase AFAICT? Also, please add a comment explaining why > the test is skipped, perhaps referencing the PR. Here's what I'm checking in: commit cd378936f38da434298b7adb5e03dc53d1a35ab8 Author: Jason Merrill Date: Wed Mar 6 10:16:34 2013 -0500 PR debug/53363 * g++.dg/debug/dwarf2/thunk1.C: Skip on darwin. diff --git a/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C b/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C index 1eb1295..c47ade6 100644 --- a/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C +++ b/gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C @@ -3,6 +3,9 @@ // { dg-options "-g -fpic -fno-dwarf2-cfi-asm" } // { dg-final { scan-assembler-times "LFB3" 5 } } +// Darwin doesn't use the thunk for PIC. +// { dg-skip-if { target *-*-darwin* } } + template void f(T t) { } int main()