From patchwork Tue Feb 26 10:42:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Carlini X-Patchwork-Id: 223190 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D469B2C031C for ; Tue, 26 Feb 2013 21:42:43 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1362480166; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Message-ID:Date:From:User-Agent:MIME-Version: To:CC:Subject:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=iolTlEz7QjsTOp/Zg7jZ7GistVY=; b=LLURG250GP1tRSg 2t7rWU2qWEmjyIrLOJva05SPX4aObIkaQgHmfzZyl6nEtyueKAoSXVCc8zPNqwT1 4KsIjqko2wrjcvcFkK3cX4C/6gwaoMZQmTxic2KisJ0E4TTLDZjTjCN7N+RKNcCL Rmmk/GHfkovkydYbCAnN32kCqR9k= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=LI8LXJz4CVQYn1BFRYWjRUXdyw/ULm1Goh5RmaJK48nsqsSbMv/6aDYcaLcJMx pjGkyarOrl89b9cBmGhqqzUDtdD9n9J4n/+l4grx2dC99HIqNDwv0KCKse+myDk9 MrC85R5kWbEvIbUqI/rhog90fGJahNtmr9e7Y6LRk4Jl8=; Received: (qmail 28504 invoked by alias); 26 Feb 2013 10:42:37 -0000 Received: (qmail 28426 invoked by uid 22791); 26 Feb 2013 10:42:36 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL, BAYES_00, RCVD_IN_HOSTKARMA_NO, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, TW_FN, TW_KF X-Spam-Check-By: sourceware.org Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Feb 2013 10:42:23 +0000 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r1QAgLcP012649 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Feb 2013 10:42:22 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r1QAgK01008772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 26 Feb 2013 10:42:21 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r1QAgK6a012049; Tue, 26 Feb 2013 04:42:20 -0600 Received: from [192.168.1.4] (/79.33.220.13) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 Feb 2013 02:42:20 -0800 Message-ID: <512C918A.6090903@oracle.com> Date: Tue, 26 Feb 2013 11:42:18 +0100 From: Paolo Carlini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" CC: Jason Merrill Subject: [C++ Patch, obvious?] PR 55632 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, I was wondering whether we want to apply as obvious the below (given the cp_storage_class enum) and resolve the PR. Thanks, Paolo. //////////////////////// 2013-02-26 David Binderman PR c++/55632 * decl.c (grokdeclarator): Tidy publicp assignment. Index: decl.c =================================================================== --- decl.c (revision 196276) +++ decl.c (working copy) @@ -10634,9 +10634,8 @@ grokdeclarator (const cp_declarator *declarator, } } - /* Record presence of `static'. */ + /* Record whether the function is public. */ publicp = (ctype != NULL_TREE - || storage_class == sc_extern || storage_class != sc_static); decl = grokfndecl (ctype, type, original_name, parms, unqualified_id,