From patchwork Fri Jan 11 12:16:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 211319 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7E9D12C026E for ; Fri, 11 Jan 2013 23:16:35 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1358511395; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=2SragoQqUuhclUfsnkUBIirX1xs=; b=pmQaN6RNS6Kls7+ KpJ+K65Pr9wleKnhksa1p/2i4p0v51zu9ZKHfy0Mbx4GnlLuBTls3jI82uUqGBho fdi/zPzgUYdgmzWLXpFPEP9umKwtJ31Zh5l3bMhQ5GieopIyshlxQqCow2hV7us3 9/27KLNHVUBwTHadFk7DVrqn0HlM= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:X-RZG-AUTH:X-RZG-CLASS-ID:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=O29LmCBHsBkKR3YmtJiLII65G9jFQtD+F+DUXoF/qD/Hr6pC3+8AxZ5zQOpCfs HFwP6lnJ96Si58rEskiYLqyRmMKGldQeCMXizV0zGv5JvxFjcMoPTsO5T508GHq8 Hy0EbzaRrsZBhoFmqFqqEPhi8MbpL9GSUEdZuiaiG9fms=; Received: (qmail 16032 invoked by alias); 11 Jan 2013 12:16:28 -0000 Received: (qmail 16005 invoked by uid 22791); 11 Jan 2013 12:16:26 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=BAYES_00, KHOP_THREADED, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_NO, SPF_NEUTRAL X-Spam-Check-By: sourceware.org Received: from mo-p05-ob.rzone.de (HELO mo-p05-ob.rzone.de) (81.169.146.180) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Jan 2013 12:16:21 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT2k715jHQaJercGObUOFkj18odoYNahU4Q== X-RZG-CLASS-ID: mo05 Received: from [192.168.0.22] (business-188-111-022-002.static.arcor-ip.net [188.111.22.2]) by smtp.strato.de (josoe mo29) (RZmta 31.12 AUTH) with ESMTPA id u07b54p0BBdwnh ; Fri, 11 Jan 2013 13:16:18 +0100 (CET) Message-ID: <50F00291.4040008@gcc.gnu.org> Date: Fri, 11 Jan 2013 13:16:17 +0100 From: Georg-Johann Lay User-Agent: Thunderbird 2.0.0.24 (X11/20100302) MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Ian Lance Taylor Subject: Re: [patch,libgcc] Fix fixed-bit.c build warning References: <50EFE80F.5050506@gjlay.de> In-Reply-To: <50EFE80F.5050506@gjlay.de> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Georg-Johann Lay wrote: > Variables min_high and min_low are set but not used which cases build warnings, > fixed by this patch. Better attach the patch... > Build fine for i686-pc-linux-gnu and avr-unknown-none, the latter definitely > using this code. > > Ok for trunk? > > Johann > > > * fixed-bit.c (SATFRACT) : Only > declare / set min_low, min_high if TO_MODE_UNSIGNED == 0. > (SATFRACT) : Only declare / set min_low, > min_high if FROM_MODE_UNSIGNED == 0 and TO_MODE_UNSIGNED == 0. Index: libgcc/fixed-bit.c =================================================================== --- libgcc/fixed-bit.c (revision 194964) +++ libgcc/fixed-bit.c (working copy) @@ -761,11 +761,12 @@ SATFRACT (FROM_FIXED_C_TYPE a) #if FROM_MODE_UNSIGNED == 0 BIG_SINT_C_TYPE high, low; BIG_SINT_C_TYPE max_high, max_low; +#if TO_MODE_UNSIGNED == 0 BIG_SINT_C_TYPE min_high, min_low; +#endif #else BIG_UINT_C_TYPE high, low; BIG_UINT_C_TYPE max_high, max_low; - BIG_UINT_C_TYPE min_high, min_low; #endif #if TO_FBITS > FROM_FBITS BIG_UINT_C_TYPE utemp; @@ -812,13 +813,12 @@ SATFRACT (FROM_FIXED_C_TYPE a) #endif #if TO_MODE_UNSIGNED == 0 - min_high = -1; stemp = (BIG_SINT_C_TYPE)1 << (BIG_WIDTH - 1); stemp = stemp >> (BIG_WIDTH - 1 - TO_I_F_BITS); +#if FROM_MODE_UNSIGNED == 0 + min_high = -1; min_low = stemp; -#else - min_high = 0; - min_low = 0; +#endif #endif #if FROM_MODE_UNSIGNED == 0 && TO_MODE_UNSIGNED == 0 @@ -957,7 +957,7 @@ FRACT (FROM_INT_C_TYPE a) #endif /* defined(FRACT) && FROM_TYPE == 1 && TO_TYPE == 4 */ /* Signed int -> Fixed with saturation. */ -#if defined(SATFRACT) && defined(L_satfract) &&FROM_TYPE == 1 && TO_TYPE == 4 +#if defined(SATFRACT) && defined(L_satfract) && FROM_TYPE == 1 && TO_TYPE == 4 TO_FIXED_C_TYPE SATFRACT (FROM_INT_C_TYPE a) { @@ -966,8 +966,8 @@ SATFRACT (FROM_INT_C_TYPE a) FROM_INT_C_TYPE x = a; BIG_SINT_C_TYPE high, low; BIG_SINT_C_TYPE max_high, max_low; - BIG_SINT_C_TYPE min_high, min_low; #if TO_MODE_UNSIGNED == 0 + BIG_SINT_C_TYPE min_high, min_low; BIG_SINT_C_TYPE stemp; #endif #if BIG_WIDTH != TO_FBITS @@ -1008,12 +1008,7 @@ SATFRACT (FROM_INT_C_TYPE a) stemp = (BIG_SINT_C_TYPE)1 << (BIG_WIDTH - 1); stemp = stemp >> (BIG_WIDTH - 1 - TO_I_F_BITS); min_low = stemp; -#else - min_high = 0; - min_low = 0; -#endif -#if TO_MODE_UNSIGNED == 0 /* Signed -> Signed. */ if ((BIG_SINT_C_TYPE) high > (BIG_SINT_C_TYPE) max_high || ((BIG_SINT_C_TYPE) high == (BIG_SINT_C_TYPE) max_high