| Message ID | 5099345E.9060100@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 11/06/2012 05:01 PM, Florian Weimer wrote: > On 11/06/2012 04:55 PM, Jason Merrill wrote: >> On 11/05/2012 12:52 PM, Florian Weimer wrote: >>> +// Avoid use of none-overridable new/delete operators in shared >> >> Typo: that should be "non-overridable" >> >> Jason > > Thanks, this patch fixes both instances. I figured I could commit this as obvious, so I did that in r193326.
On 11/08/2012 10:54 AM, Florian Weimer wrote:
> I figured I could commit this as obvious, so I did that in r193326.
Of course. Thanks again!
Paolo.
PS: as you may have noticed, I adjusted your new code to not throw,
instead abort when __EXCEPTIONS is not defined: in general, we want the
library to build also with -fno-exceptions and throw doesn't even
compile in that case. Of course such a library isn't strictly conforming
but In know quite a few users want the option.
gcc/testsuite/ChangeLog: (revision 193243) 2012-11-06 Florian Weimer <fweimer@redhat.com> * g++.old-deja/g++.abi/cxa_vec.C: Fix typo in comment. libstdc++-v3/ChangeLog: 2012-11-06 Florian Weimer <fweimer@redhat.com> * testsuite/18_support/cxa_vec.cc: Fix typo in comment. Index: gcc/testsuite/g++.old-deja/g++.abi/cxa_vec.C =================================================================== --- gcc/testsuite/g++.old-deja/g++.abi/cxa_vec.C (revision 193243) +++ gcc/testsuite/g++.old-deja/g++.abi/cxa_vec.C (working copy) @@ -5,7 +5,7 @@ // are resolved when the kernel is linked. // { dg-do run { xfail { powerpc-ibm-aix* || vxworks_kernel } } } // { dg-options "-flat_namespace" { target *-*-darwin[67]* } } -// Avoid use of none-overridable new/delete operators in shared +// Avoid use of non-overridable new/delete operators in shared // { dg-options "-static" { target *-*-mingw* } } // Test __cxa_vec routines // Copyright (C) 2000, 2005 Free Software Foundation, Inc. Index: libstdc++-v3/testsuite/18_support/cxa_vec.cc =================================================================== --- libstdc++-v3/testsuite/18_support/cxa_vec.cc (revision 193243) +++ libstdc++-v3/testsuite/18_support/cxa_vec.cc (working copy) @@ -1,5 +1,5 @@ // { dg-do run } -// Avoid use of none-overridable new/delete operators in shared +// Avoid use of non-overridable new/delete operators in shared // { dg-options "-static" { target *-*-mingw* } } // Test __cxa_vec routines // Copyright (C) 2000-2012 Free Software Foundation, Inc.