From patchwork Fri May 25 14:48:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 161376 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4F73EB6F86 for ; Sat, 26 May 2012 00:49:01 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1338562142; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Received:Message-ID:Date:From:User-Agent:MIME-Version: To:Cc:Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=fTfJjflIi4Pzj6Y5hVzZ6BgCHQg=; b=o3CJRG/CFGaqe0Aux2idQnB9QP7mlwrW1NbejYSBifIuX3m0E8VrRkrPDfB84N 6d65SiqI3bWY5xhHf2gLcnZeDrWFFRUud7PVyxo1sgQMsZGZFWtiK+EXQWaaM9r2 nCeox7onz2YGmgMWaggpd6WCktozDOguUvvDU6bgT0/ak= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Cc:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=GqcWr2m256sm7HDcmbAeypFSXhy86RzsMUDMTglH32TwjLYgnr3+MC+RfsOsvJ aI8BHxg98CKPU6ZMZ+s6bQWqOEyNcJ3OPSH6dqoM+ZYecpdpj/YpWFyrlSnauQ7T hdgnI5UV6UzDCbmQbAlixV7MOhcbe8XojMx68S0S0oleg=; Received: (qmail 32149 invoked by alias); 25 May 2012 14:48:57 -0000 Received: (qmail 32140 invoked by uid 22791); 25 May 2012 14:48:55 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from eu1sys200aog116.obsmtp.com (HELO eu1sys200aog116.obsmtp.com) (207.126.144.141) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 May 2012 14:48:42 +0000 Received: from beta.dmz-eu.st.com ([164.129.1.35]) (using TLSv1) by eu1sys200aob116.postini.com ([207.126.147.11]) with SMTP ID DSNKT7+bx84gzM53aOXFsNh1Vn5XtJ3G3/H+@postini.com; Fri, 25 May 2012 14:48:41 UTC Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 798ADB3; Fri, 25 May 2012 14:48:39 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas1.st.com [10.75.90.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id DE1A94767; Fri, 25 May 2012 14:48:38 +0000 (GMT) Received: from [164.129.122.162] (164.129.122.162) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.192.1; Fri, 25 May 2012 16:48:38 +0200 Message-ID: <4FBF9BC6.4000809@st.com> Date: Fri, 25 May 2012 16:48:38 +0200 From: Christophe Lyon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:12.0) Gecko/20120420 Thunderbird/12.0 MIME-Version: 1.0 To: Ramana Radhakrishnan Cc: gcc-patches Subject: Re: [PATCH] ARM/NEON: vld1q_dup_s64 builtin References: <4FAA445A.8080605@st.com> <4FABDF5F.6070105@st.com> <4FB3B0CA.1090605@st.com> <4FBA07DF.6070801@st.com> In-Reply-To: <4FBA07DF.6070801@st.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 21.05.2012 11:16, Christophe Lyon wrote: >> I tried applying your patch but ran into trouble with patch not liking >> this . My suspicion is mailer munging white spaces in some form - >> Could you send the patch as an attachment please rather than inline in >> your mail ? >> >> regards, >> Ramana >> > Here it is, as an attachment. Note however that this patch is against GCC-4.6.3. > > Thanks for testing. > > Christophe. > Hi, I have attached the version for GCC trunk. Christophe. 2012-05-25 Christophe Lyon * gcc/config/arm/neon.md (neon_vld1_dup): Restrict to VQ operands. (neon_vld1_dupv2di): New, fixes vld1q_dup_s64. * gcc/testsuite/gcc.target/arm/neon-vld1_dupQ.c: New test. diff --git a/gcc/config/arm/neon.md b/gcc/config/arm/neon.md index 4568dea..0a4d00b 100644 --- a/gcc/config/arm/neon.md +++ b/gcc/config/arm/neon.md @@ -4397,20 +4397,32 @@ ) (define_insn "neon_vld1_dup" - [(set (match_operand:VQX 0 "s_register_operand" "=w") - (unspec:VQX [(match_operand: 1 "neon_struct_operand" "Um")] + [(set (match_operand:VQ 0 "s_register_operand" "=w") + (unspec:VQ [(match_operand: 1 "neon_struct_operand" "Um")] UNSPEC_VLD1_DUP))] "TARGET_NEON" { - if (GET_MODE_NUNITS (mode) > 2) - return "vld1.\t{%e0[], %f0[]}, %A1"; - else - return "vld1.\t%h0, %A1"; + return "vld1.\t{%e0[], %f0[]}, %A1"; } [(set (attr "neon_type") - (if_then_else (gt (const_string "") (const_string "1")) - (const_string "neon_vld2_2_regs_vld1_vld2_all_lanes") - (const_string "neon_vld1_1_2_regs")))] + (const_string "neon_vld2_2_regs_vld1_vld2_all_lanes"))] +) + +(define_insn_and_split "neon_vld1_dupv2di" + [(set (match_operand:V2DI 0 "s_register_operand" "=w") + (vec_duplicate:V2DI (match_operand:DI 1 "neon_struct_operand" "Um")))] + "TARGET_NEON" + "#" + "&& reload_completed" + [(const_int 0)] + { + rtx tmprtx = gen_lowpart (DImode, operands[0]); + emit_insn (gen_neon_vld1_dupdi (tmprtx, operands[1])); + emit_move_insn (gen_highpart (DImode, operands[0]), tmprtx ); + DONE; + } + [(set_attr "length" "8") + (set (attr "neon_type") (const_string "neon_vld2_2_regs_vld1_vld2_all_lanes"))] ) (define_expand "vec_store_lanes" diff --git a/gcc/testsuite/gcc.target/arm/neon-vld1_dupQ.c b/gcc/testsuite/gcc.target/arm/neon-vld1_dupQ.c new file mode 100644 index 0000000..b5793bf --- /dev/null +++ b/gcc/testsuite/gcc.target/arm/neon-vld1_dupQ.c @@ -0,0 +1,24 @@ +/* Test the `vld1q_s64' ARM Neon intrinsic. */ + +/* { dg-do run } */ +/* { dg-require-effective-target arm_neon_hw } */ +/* { dg-options "-O0" } */ +/* { dg-add-options arm_neon } */ + +#include "arm_neon.h" +#include + +int main (void) +{ + int64x1_t input[2] = {(int64x1_t)0x0123456776543210LL, + (int64x1_t)0x89abcdeffedcba90LL}; + int64x1_t output[2] = {0, 0}; + int64x2_t var = vld1q_dup_s64(input); + + vst1q_s64(output, var); + if (output[0] != (int64x1_t)0x0123456776543210LL) + abort(); + if (output[1] != (int64x1_t)0x0123456776543210LL) + abort(); + return 0; +}