From patchwork Mon May 7 23:07:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias Klose X-Patchwork-Id: 157489 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 37B3AB6FAB for ; Tue, 8 May 2012 09:07:59 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1337036879; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:Subject: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=WfmyNbT JzD+U8I4pFB+URWB9SEA=; b=JQjGlwJm6fdkKYw0TIyjbcw6t2YG+EdCDrnJCCe /bCGOc0KgrVyhVxve1Vd+u8lYzYr+jWtSejfp/J6vl20SKXbevCu102bUodGspGC JLxqqxjKRgROFBRaWxM2K+FLSOA591An/Ed49fDb3PSXvpbk7ns8xgTwaLva+6k1 3HCA= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:Subject:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=p5QXFzdHkNWJ40eB8N+b5N6kAXHdJ8iMX6f5v727gV9XaFkkrM1HxKEv/YWx4+ Jait7z6vAa+uH2zAm0WUZSt8jzXuQSsMfkWpvkz15iy1gWEBgrj2oQFyqd3dJEqs czEPQDtt8Cnw3krdrpegq2J3lLkdAI+aF11cM2tfs4T54=; Received: (qmail 13969 invoked by alias); 7 May 2012 23:07:55 -0000 Received: (qmail 13950 invoked by uid 22791); 7 May 2012 23:07:54 -0000 X-SWARE-Spam-Status: No, hits= required= tests= Received: from youngberry.canonical.com (HELO youngberry.canonical.com) (91.189.89.112) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 May 2012 23:07:45 +0000 Received: from [216.64.156.98] (helo=[10.155.43.193]) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1SRX1s-00017x-KY for gcc-patches@gcc.gnu.org; Mon, 07 May 2012 23:07:44 +0000 Message-ID: <4FA855BE.9000103@ubuntu.com> Date: Tue, 08 May 2012 01:07:42 +0200 From: Matthias Klose User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: GCC Patches Subject: [patch] don't check for execute bits of the liblto plugin Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org The lto plugin is installed without x bits set, but gcc-ar.c still checks for the execute bits. There is no need to have the lto plugin to have the x bits set, so just check that it is readable. Ok for the trunk and the 4.7 branch? Matthias * (main): Don't check for execute bits for the plugin. --- gcc/gcc-ar.c +++ gcc/gcc-ar.c @@ -70,7 +70,7 @@ dir_separator, LTOPLUGINSONAME, NULL); - if (access (plugin, X_OK)) + if (access (plugin, R_OK)) { fprintf (stderr, "%s: Cannot find plugin %s\n", av[0], plugin); exit (1);