diff mbox

[AVR] : Fix missing prototype warning for ACCUMULATE_OUTGOING_ARGS

Message ID 4F3BD316.7080807@gjlay.de
State New
Headers show

Commit Message

Georg-Johann Lay Feb. 15, 2012, 3:45 p.m. UTC 
Some parts outside the backend use ACCUMULATE_OUTGOING_ARGS without including
tm_p.h which lead to a build warning because avr.h does

#define ACCUMULATE_OUTGOING_ARGS avr_accumulate_outgoing_args()

This patcs moved the prototype from avr-protos.h to avr.h:

	* config/avr/avr-protos.h (avr_accumulate_outgoing_args): Move
	prototype from here to...
	* config/avr/avr.h: ...here.

Ok for trunk?

Johann

Comments

Denis Chertykov Feb. 21, 2012, 4:31 p.m. UTC | #1 
2012/2/15 Georg-Johann Lay <avr@gjlay.de>:
> Some parts outside the backend use ACCUMULATE_OUTGOING_ARGS without including
> tm_p.h which lead to a build warning because avr.h does
>
> #define ACCUMULATE_OUTGOING_ARGS avr_accumulate_outgoing_args()
>
> This patcs moved the prototype from avr-protos.h to avr.h:
>
>        * config/avr/avr-protos.h (avr_accumulate_outgoing_args): Move
>        prototype from here to...
>        * config/avr/avr.h: ...here.
>
> Ok for trunk?
>

Approved.

Denis.
Georg-Johann Lay Feb. 22, 2012, 2:25 p.m. UTC | #2 
Denis Chertykov wrote:
> 2012/2/15 Georg-Johann Lay:
>> Some parts outside the backend use ACCUMULATE_OUTGOING_ARGS without including
>> tm_p.h which lead to a build warning because avr.h does
>>
>> #define ACCUMULATE_OUTGOING_ARGS avr_accumulate_outgoing_args()
>>
>> This patcs moved the prototype from avr-protos.h to avr.h:
>>
>>        * config/avr/avr-protos.h (avr_accumulate_outgoing_args): Move
>>        prototype from here to...
>>        * config/avr/avr.h: ...here.
>>
>> Ok for trunk?
>>
> 
> Approved.
> 
> Denis.

Committed with that change

bool avr_accumulate_outgoing_args (void)
to
int avr_accumulate_outgoing_args (void)

http://gcc.gnu.org/viewcvs?view=revision&revision=184475

Johann
diff mbox

Patch

Index: config/avr/avr-protos.h
===================================================================
--- config/avr/avr-protos.h     (revision 184266)
+++ config/avr/avr-protos.h     (working copy)
@@ -33,7 +33,6 @@  extern int avr_simple_epilogue (void);
 extern int avr_hard_regno_rename_ok (unsigned int, unsigned int);
 extern rtx avr_return_addr_rtx (int count, rtx tem);
 extern void avr_register_target_pragmas (void);
-extern bool avr_accumulate_outgoing_args (void);
 extern void avr_init_expanders (void);

 #ifdef TREE_CODE
Index: config/avr/avr.h
===================================================================
--- config/avr/avr.h    (revision 184269)
+++ config/avr/avr.h    (working copy)
@@ -676,6 +676,7 @@  struct GTY(()) machine_function
    required in order for pushes to be generated.  */
 #define PUSH_ROUNDING(X)       (X)

+extern bool avr_accumulate_outgoing_args (void);
 #define ACCUMULATE_OUTGOING_ARGS avr_accumulate_outgoing_args()

 #define INIT_EXPANDERS avr_init_expanders()