From patchwork Thu Sep 8 03:09:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 113860 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 9405AB6F87 for ; Thu, 8 Sep 2011 13:10:05 +1000 (EST) Received: (qmail 12427 invoked by alias); 8 Sep 2011 03:10:02 -0000 Received: (qmail 12385 invoked by uid 22791); 8 Sep 2011 03:10:01 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Sep 2011 03:09:40 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8839d7g005530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Sep 2011 23:09:39 -0400 Received: from houston.quesejoda.com (vpn-233-58.phx2.redhat.com [10.3.233.58]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p8839dKi025989; Wed, 7 Sep 2011 23:09:39 -0400 Message-ID: <4E6831F2.4050603@redhat.com> Date: Wed, 07 Sep 2011 22:09:38 -0500 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: gcc-patches , Andrew MacLeod Subject: [cxx-mem-model] Call torture-finish in testing infrastructure Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Apparently, if you don't call torture-finish, subsequent tests in dg.exp inherit CFLAGS incorrectly. Serves me right for not testing the entire testsuite when making changes to memmodel.exp. When will I learn to expect the unexpected when making seemingly unrelated changes...? Committed to branch. * gcc.dg/memmodel/memmodel.exp: Call torture-finish. * g++.dg/memmodel/memmodel.exp: Likewise. Index: gcc.dg/memmodel/memmodel.exp =================================================================== --- gcc.dg/memmodel/memmodel.exp (revision 178607) +++ gcc.dg/memmodel/memmodel.exp (working copy) @@ -54,4 +54,5 @@ if [info exists guality_gdb_name] { unsetenv GUALITY_GDB_NAME } +torture-finish dg-finish Index: g++.dg/memmodel/memmodel.exp =================================================================== --- g++.dg/memmodel/memmodel.exp (revision 178607) +++ g++.dg/memmodel/memmodel.exp (working copy) @@ -54,4 +54,5 @@ if [info exists guality_gdb_name] { unsetenv GUALITY_GDB_NAME } +torture-finish dg-finish