From patchwork Fri Nov 12 14:33:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 70972 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id BA1CFB713A for ; Sat, 13 Nov 2010 01:34:19 +1100 (EST) Received: (qmail 29273 invoked by alias); 12 Nov 2010 14:34:14 -0000 Received: (qmail 29142 invoked by uid 22791); 12 Nov 2010 14:34:12 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-px0-f175.google.com (HELO mail-px0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Nov 2010 14:33:26 +0000 Received: by pxi17 with SMTP id 17so658653pxi.20 for ; Fri, 12 Nov 2010 06:33:24 -0800 (PST) Received: by 10.143.39.15 with SMTP id r15mr1859055wfj.62.1289572404137; Fri, 12 Nov 2010 06:33:24 -0800 (PST) Received: from yakj.usersys.redhat.com (s209p8.home.99maxprogres.cz [85.93.118.17]) by mx.google.com with ESMTPS id w42sm3955283wfh.15.2010.11.12.06.33.20 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 12 Nov 2010 06:33:22 -0800 (PST) Message-ID: <4CDD502D.9060405@gnu.org> Date: Fri, 12 Nov 2010 15:33:17 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101027 Fedora/3.1.6-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.6 MIME-Version: 1.0 Newsgroups: gmane.comp.gcc.patches To: Joern Rennecke CC: gcc-patches@gcc.gnu.org, DJ Delorie , Alexandre Oliva Subject: Re: Ping^2: RFA (build): Avoid circular dependency References: <20100629172139.7sxigvan4g48koss-nzlynne@webmail.spamcop.net> <20101104090834.yzg2549rks8o84wg-nzlynne@webmail.spamcop.net> <20101112091310.xfc3pvh9ogw0sskg-nzlynne@webmail.spamcop.net> In-Reply-To: <20101112091310.xfc3pvh9ogw0sskg-nzlynne@webmail.spamcop.net> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 11/12/2010 03:13 PM, Joern Rennecke wrote: >> I don't have the sources at hand, so I cannot see right now what is >> the full chain of dependencies. >> >> I'll review the patch early next week. > > Are you still planning to do the review in the near future? Yes. Your patch has the disadvantage that a normal "make" will not do the check anymore, because you removed the dependency from all to s-tm-texi (which previously went all -> info -> gccint.info -> tm.texi -> s-tm-texi). What about this instead, which breaks the circular dependency by making tm.texi phony. This way "$(MAKE) tm.texi" is effectively a synonym of "$(MAKE s-tm-texi)". Does this work for you? Paolo --- Makefile.in (revision 166517) +++ Makefile.in (working copy) @@ -3688,7 +3688,10 @@ s-constrs-h: $(MD_DEPS) build/genpreds$( $(STAMP) s-constrs-h target-hooks-def.h: s-target-hooks-def-h; @true -tm.texi: s-tm-texi; @true + +all: tm.texi +tm.texi: force + $(MAKE) s-tm-texi s-target-hooks-def-h: build/genhooks$(build_exeext) $(RUN_GEN) build/genhooks$(build_exeext) > tmp-target-hooks-def.h