From patchwork Tue Sep 7 16:12:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: JonY X-Patchwork-Id: 64034 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 04DCBB6EEF for ; Wed, 8 Sep 2010 02:30:17 +1000 (EST) Received: (qmail 2624 invoked by alias); 7 Sep 2010 16:30:14 -0000 Received: (qmail 2614 invoked by uid 22791); 7 Sep 2010 16:30:13 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-px0-f175.google.com (HELO mail-px0-f175.google.com) (209.85.212.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Sep 2010 16:30:03 +0000 Received: by pxi11 with SMTP id 11so1401998pxi.20 for ; Tue, 07 Sep 2010 09:30:01 -0700 (PDT) Received: by 10.114.59.1 with SMTP id h1mr68817waa.47.1283877001277; Tue, 07 Sep 2010 09:30:01 -0700 (PDT) Received: from [192.168.1.253] ([60.52.92.113]) by mx.google.com with ESMTPS id x9sm13799360waj.15.2010.09.07.09.29.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 07 Sep 2010 09:30:00 -0700 (PDT) Message-ID: <4C866458.50401@users.sourceforge.net> Date: Wed, 08 Sep 2010 00:12:08 +0800 From: JonY User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080213 Thunderbird/2.0.0.12 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: "H.J. Lu" CC: Kai Tietz , Paolo Bonzini , Dave Korn , Gcc Patch List Subject: Re: [PATCH] Allow decimal floats for mingw-w64 References: <4C73D99C.5050205@users.sourceforge.net> <4C8040D2.90002@gmail.com> <4C803F00.5080500@users.sourceforge.net> <4C865A75.8050707@users.sourceforge.net> <4C8660B6.90704@users.sourceforge.net> In-Reply-To: <4C8660B6.90704@users.sourceforge.net> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 9/7/2010 23:56, JonY wrote: > On 9/7/2010 23:57, H.J. Lu wrote: >> On Tue, Sep 7, 2010 at 8:29 AM, JonY wrote: >>> On 9/7/2010 22:06, H.J. Lu wrote: >>>> >>>> On Tue, Sep 7, 2010 at 1:51 AM, Kai Tietz >>>> wrote: >>>>> >>>>> 2010/9/3 JonY: >>>>>> >>>>>> On 9/3/2010 08:26, Dave Korn wrote: >>>>>>> >>>>>>> On 24/08/2010 16:06, Kai Tietz wrote: >>>>>>>> >>>>>>>> 2010/8/24 JonY: >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> Attached patch enables i?86-w64-mingw32 and x86_64-w64-mingw32 >>>>>>>>> decimal >>>>>>>>> float >>>>>>>>> support with bid. >>>>>>>>> >>>>>>>>> Tested with x86_64-w64-mingw32. Is attached patch OK for trunk? >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> 2010-08-24 Jonathan Yong >>>>>>>>> >>>>>>>>> * configure.ac: Allow w64 targets to use bid decimal floats. >>>>>>>>> * configure: Regenerated. >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> Patch is from my side ok. I added Dave to CC. Maybe he wants >>>>>>>> that it >>>>>>>> gets added for cygwin, too? >>>>>>> >>>>>>> I'm currently testing a build that I did with Uros' patch and >>>>>>> manually >>>>>>> configuring with '--enable-decimal-float' and it seems to be going >>>>>>> pretty >>>>>>> well, so yes please Jon, if you don't mind spinning another respin. >>>>>>> >>>>>> >>>>>> Spinning another respin? I thought --enable-decimal-float was ignored >>>>>> for cygwin and mingw? >>>>>> >>>>>>> BTW, re Ralf's earlier point: for preference please actually /omit/ >>>>>>> the >>>>>>> diffs of the generated configure files altogether, we only need >>>>>>> to see >>>>>>> the >>>>>>> change to the .ac file, because autoconf is very deterministic, >>>>>>> and the >>>>>>> actual >>>>>>> configure file diffs often contain tons of uninformative noise >>>>>>> from the >>>>>>> expansions of all the macros and the changes in error line number >>>>>>> reporting(*). >>>>>>> >>>>>> >>>>>> Yes, I was wondering about that. New patch attached, this time only >>>>>> configure.ac and the new m4 file. >>>>>> >>>>> >>>>> Hello, >>>>> >>>>> Patch is ok. Thanks for reworking this but I would like that Paolo >>>>> takes a look on it, too. >>>>> >>>> >>>> Does this patch apply to trunk? >>>> >>>> >>> >>> Well, its supposed to be for gcc trunk. >>> >>> I did make another patch without the autoreconf stuff added, did it get >>> lost? >>> >> >> Where is it? Have you tried it on today's trunk? >> >> > > I seems somebody has already committed a somewhat related patch, I'll > need to rework mine. Looks like most of the changes are in, the only parts needed changing was: Index: config/dfp.m4 =================================================================== --- config/dfp.m4 (revision 163959) +++ config/dfp.m4 (working copy) @@ -20,7 +20,9 @@ ], [ case $1 in - powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux*) + powerpc*-*-linux* | i?86*-*-linux* | x86_64*-*-linux* | s390*-*-linux* | \ + i?86*-*-mingw* | x86_64*-*-mingw* |\ + i?86*-*-cygwin* ) enable_decimal_float=yes ;; *)