From patchwork Thu Sep 9 13:19:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1526199 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=bmtpeG+e; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H503G5RJxz9tk7 for ; Thu, 9 Sep 2021 23:19:37 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0AA6384A88E for ; Thu, 9 Sep 2021 13:19:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0AA6384A88E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1631193574; bh=FlNHa0pq16tQw2nGEniQ1urs4zEIcGZRueD4au6RrXI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=bmtpeG+e3RXURdhZRaVLs3rB5/nqwzSIKAlJdoVyWANvgvhP0Dz/DOiA6aBO/SJGn uJZ7zzOWB91W7x6FXqz8ZEfk3D3di1bBRbC29drf6vnUm+Gje6xOFWYE85UDzGIrLe 30dJ4P6oClA25W9CBBhBkRJLpy5DQRr10vVhe1GM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 291B23858C2C for ; Thu, 9 Sep 2021 13:19:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 291B23858C2C Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0700B1FDEE; Thu, 9 Sep 2021 13:19:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DF13C13B36; Thu, 9 Sep 2021 13:19:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id F6WwNM8JOmF1EgAAMHmgww (envelope-from ); Thu, 09 Sep 2021 13:19:11 +0000 Date: Thu, 9 Sep 2021 15:19:11 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Remove dbx.h, do not set PREFERRED_DEBUGGING_TYPE from dbxcoff.h, lynx.h Message-ID: <49oqn7p0-n811-366q-p55q-1s9pq9ss8n3@fhfr.qr> MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Cc: dj@delorie.com Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" The following removes the unused config/dbx.h file and removes the setting of PREFERRED_DEBUGGING_TYPE from dbxcoff.h which is overridden by all users (djgpp/mingw/cygwin) via either including config/i386/djgpp.h or config/i386/cygming.h There are still circumstances where mingw and cygwin default to STABS, namely when HAVE_GAS_PE_SECREL32_RELOC is not defined and the target defaults to 32bit code generation. The new style handling DBX_DEBUGGING_INFO is in line with dbxelf.h which does not define PREFERRED_DEBUGGING_TYPE either. The patch also removes the PREFERRED_DEBUGGING_TYPE define from lynx.h which always follows elfos.h already defaulting to DWARF, so the comment about STABS being the default is misleading and outdated. There's no listed maintainer for Lynx OS. I have not tested this in any ways but I also have no idea how to meaningfully do so. OK? Thanks, Richard. 2021-09-09 Richard Biener PR target/102255 * config/dbx.h: Remove. * config/dbxcoff.h: Do not define PREFERRED_DEBUGGING_TYPE. * config/lynx.h: Likewise. --- gcc/config/dbx.h | 32 -------------------------------- gcc/config/dbxcoff.h | 6 ------ gcc/config/lynx.h | 7 ------- 3 files changed, 45 deletions(-) delete mode 100644 gcc/config/dbx.h diff --git a/gcc/config/dbx.h b/gcc/config/dbx.h deleted file mode 100644 index b270a07cf9f..00000000000 --- a/gcc/config/dbx.h +++ /dev/null @@ -1,32 +0,0 @@ -/* Prefer DBX (stabs) debugging information. - Copyright (C) 1996-2021 Free Software Foundation, Inc. - -This file is part of GCC. - -GCC is free software; you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation; either version 3, or (at your option) -any later version. - -GCC is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. - -Under Section 7 of GPL version 3, you are granted additional -permissions described in the GCC Runtime Library Exception, version -3.1, as published by the Free Software Foundation. - -You should have received a copy of the GNU General Public License and -a copy of the GCC Runtime Library Exception along with this program; -see the files COPYING3 and COPYING.RUNTIME respectively. If not, see -. */ - -/* This file causes gcc to prefer using DBX (stabs) debugging - information. The configure script will add a #include of this file - to tm.h when --with-stabs is used for certain targets. */ - -#define DBX_DEBUGGING_INFO 1 - -#undef PREFERRED_DEBUGGING_TYPE -#define PREFERRED_DEBUGGING_TYPE DBX_DEBUG diff --git a/gcc/config/dbxcoff.h b/gcc/config/dbxcoff.h index d491cff961f..bd705f93711 100644 --- a/gcc/config/dbxcoff.h +++ b/gcc/config/dbxcoff.h @@ -25,12 +25,6 @@ along with GCC; see the file COPYING3. If not see #define DBX_DEBUGGING_INFO 1 -/* Generate DBX debugging information by default. */ - -#ifndef PREFERRED_DEBUGGING_TYPE -#define PREFERRED_DEBUGGING_TYPE DBX_DEBUG -#endif - /* Be function-relative for block and source line stab directives. */ #define DBX_BLOCKS_FUNCTION_RELATIVE 1 diff --git a/gcc/config/lynx.h b/gcc/config/lynx.h index 020cc97352f..14387040cba 100644 --- a/gcc/config/lynx.h +++ b/gcc/config/lynx.h @@ -158,13 +158,6 @@ along with GCC; see the file COPYING3. If not see while (0) #endif -/* Keep the *_DEBUGGING_INFO defines from elfos.h except that stabs is - the default on LynxOS. */ - -#ifndef PREFERRED_DEBUGGING_TYPE -# define PREFERRED_DEBUGGING_TYPE DBX_DEBUG -#endif - #ifndef TARGET_POSIX_IO # define TARGET_POSIX_IO #endif