From patchwork Tue Nov 22 22:40:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 127180 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id ADAE91007D2 for ; Wed, 23 Nov 2011 09:41:08 +1100 (EST) Received: (qmail 29331 invoked by alias); 22 Nov 2011 22:41:07 -0000 Received: (qmail 29323 invoked by uid 22791); 22 Nov 2011 22:41:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from c2beaomr09.btconnect.com (HELO mail.btconnect.com) (213.123.26.187) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 22:40:51 +0000 Received: from host81-138-1-83.in-addr.btopenworld.com (EHLO thor.office) ([81.138.1.83]) by c2beaomr09.btconnect.com with ESMTP id FGT97685; Tue, 22 Nov 2011 22:40:38 +0000 (GMT) Cc: Jack Howarth , Aldy Hernandez , gcc-patches , Andrew Pinski Message-Id: <491AB668-D435-4E50-8CDF-41C7259EB360@sandoe-acoustics.co.uk> From: Iain Sandoe To: Richard Henderson In-Reply-To: <4ECC1790.40001@redhat.com> Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: [patch] support LTO of transactional memory Date: Tue, 22 Nov 2011 22:40:37 +0000 References: <4ECAA72B.90409@redhat.com> <4ECAAA6A.7020805@redhat.com> <4ECBE217.7080808@redhat.com> <4ECBEA54.4000103@redhat.com> <20111122205722.GA21689@bromo.med.uc.edu> <4ECC0F95.3020400@redhat.com> <885143B9-90F9-4B36-89DE-288C15AF3B88@sandoe-acoustics.co.uk> <4ECC146E.2080304@redhat.com> <20111122213754.GA21942@bromo.med.uc.edu> <4ECC1790.40001@redhat.com> X-Mirapoint-IP-Reputation: reputation=Good-1, source=Queried, refid=tid=0001.0A0B0302.4ECC24E5.0049, actions=tag X-Junkmail-Premium-Raw: score=8/50, refid=2.7.2:2011.11.22.215714:17:8.129, ip=81.138.1.83, rules=__MULTIPLE_RCPTS_CC_X2, __HAS_MSGID, __SANE_MSGID, __MSGID_APPLEMAIL, __TO_MALFORMED_2, __CT, __CTYPE_HAS_BOUNDARY, __CTYPE_MULTIPART, CTYPE_MULTIPART_NO_QUOTE, __CTYPE_MULTIPART_MIXED, __MIME_VERSION, __MIME_VERSION_APPLEMAIL, __BOUNCE_CHALLENGE_SUBJ, __BOUNCE_NDR_SUBJ_EXEMPT, __SUBJ_ALPHA_END, __HAS_X_MAILER, __X_MAILER_APPLEMAIL, TXT_ATTACHED, BODYTEXTP_SIZE_3000_LESS, BODY_SIZE_2000_2999, __MIME_TEXT_ONLY, RDNS_GENERIC_POOLED, BODY_SIZE_5000_LESS, RDNS_SUSP_GENERIC, __USER_AGENT_APPLEMAIL, RDNS_SUSP, BODY_SIZE_7000_LESS, NO_URI_FOUND, MIME_TEXT_ONLY_MP_MIXED, MULTIPLE_RCPTS X-Junkmail-Signature-Raw: score=unknown, refid=str=0001.0A0B0201.4ECC24EE.00C6, ss=1, fgs=0, ip=0.0.0.0, so=2010-07-22 22:03:31, dmn=2009-09-10 00:05:08, mode=multiengine X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 22 Nov 2011, at 21:43, Richard Henderson wrote: > On 11/22/2011 01:37 PM, Jack Howarth wrote: >> On x86_64-apple-darwin11, this converts the link failures into run- >> time failures >> as are seen on i386 linux. > > > These aren't supposed to be runtime tests. Did a { dg-do link } > marker get missed? this works for me if that was the intention Iain Index: gcc/testsuite/gcc.dg/lto/trans-mem-2_0.c =================================================================== --- gcc/testsuite/gcc.dg/lto/trans-mem-2_0.c (revision 181634) +++ gcc/testsuite/gcc.dg/lto/trans-mem-2_0.c (working copy) @@ -1,4 +1,5 @@ /* { dg-lto-options {{-flto -fgnu-tm}} } */ +/* { dg-lto-do link } */ extern void foobar() __attribute__((transaction_callable)); @@ -9,6 +10,8 @@ dummy(_ITM_beginTransaction) dummy(_ITM_commitTransaction) dummy(_ITM_WU4) dummy(_ITM_WU8) +dummy(_ITM_registerTMCloneTable) +dummy(_ITM_deregisterTMCloneTable) main() { Index: gcc/testsuite/gcc.dg/lto/trans-mem-1_0.c =================================================================== --- gcc/testsuite/gcc.dg/lto/trans-mem-1_0.c (revision 181634) +++ gcc/testsuite/gcc.dg/lto/trans-mem-1_0.c (working copy) @@ -1,4 +1,5 @@ /* { dg-lto-options {{-flto -fgnu-tm}} } */ +/* { dg-lto-do link } */ int i; Index: gcc/testsuite/gcc.dg/lto/trans-mem-1_1.c =================================================================== --- gcc/testsuite/gcc.dg/lto/trans-mem-1_1.c (revision 181634) +++ gcc/testsuite/gcc.dg/lto/trans-mem-1_1.c (working copy) @@ -5,3 +5,5 @@ dummy(_ITM_beginTransaction) dummy(_ITM_commitTransaction) dummy(_ITM_WU4) dummy(_ITM_WU8) +dummy(_ITM_registerTMCloneTable) +dummy(_ITM_deregisterTMCloneTable)