From patchwork Fri Jun 30 15:41:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Preudhomme X-Patchwork-Id: 782902 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wzgjy3Pw4z9sNS for ; Sat, 1 Jul 2017 01:41:26 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="iNFMs9uK"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:references:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=gMU/S4Qhk1lSfBOhG f8+qZK/OLek5FbcGA1+99j8e51kghlYCN75+jczyudocbEi/Mi/RI0L3oXVhpTNn Wjv3oHXuQv5V7/vAmaO1Xxq8J7ixvfifAxAQv0eJu5fXxLDZQDe/iCgTwJlF9QM0 SqKMO7M6i2s4VbUNQzXlmxsgyM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:from:to:references:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=03IwRWJQfDBLdSlw932B5px GXx8=; b=iNFMs9uKiHTMPkrBzxtXHDzvkZs9nAQur3k2FlOA4JqGpyx/Emiwqho xNxVnfDXHimvNXgmBJXHzH2uMerRikSd8RIM44W/g8ClNWQbOod4XojKbcejPMJc 7nWFPM+XqmVI3nwKS6c3Mc9oDgwBCDnharkiR5uVMv1X6g8Ttaok= Received: (qmail 95065 invoked by alias); 30 Jun 2017 15:41:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 93246 invoked by uid 89); 30 Jun 2017 15:41:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Best X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Jun 2017 15:41:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3C7DD80D; Fri, 30 Jun 2017 08:41:13 -0700 (PDT) Received: from [10.2.206.52] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7B7F53F41F; Fri, 30 Jun 2017 08:41:12 -0700 (PDT) Subject: Re: [PATCH, GCC/ARM, gcc-5-branch, ping2] Fix gcc.target/arm/fpscr.c From: Thomas Preudhomme To: Kyrill Tkachov , Ramana Radhakrishnan , Richard Earnshaw , "gcc-patches@gcc.gnu.org" References: <785b3156-393c-389b-e89f-571a773fc246@foss.arm.com> Message-ID: <44f75176-e932-5d97-3499-e56c4ae293f0@foss.arm.com> Date: Fri, 30 Jun 2017 16:41:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <785b3156-393c-389b-e89f-571a773fc246@foss.arm.com> X-IsSubscribed: yes Ping? Best regards, Thomas On 28/06/17 12:35, Thomas Preudhomme wrote: > Ping? > > Best regards, > > Thomas > > On 26/06/17 12:32, Thomas Preudhomme wrote: >> Hi, >> >> As raised by Christophe Lyon, fpscr.c FAILs because arm_fp_ok and arm_fp >> are not defined in GCC 5. This commit changes the test to use the same >> recipe as gcc.target/arm/cmp-2.c >> >> ChangeLog entry is as follows: >> >> >> *** gcc/testsuite/ChangeLog *** >> >> 2017-06-26 Thomas Preud'homme >> >> * gcc.target/arm/fpscr.c: Require arm_vfp_ok instead of arm_fp_ok and >> add -mfpu=vfp -mfloat-abi=softfp instead of fp_ok options. >> >> >> Ok for GCC 5? >> >> Best regards, >> >> Thomas diff --git a/gcc/testsuite/gcc.target/arm/fpscr.c b/gcc/testsuite/gcc.target/arm/fpscr.c index 7b4d71d72d8964f6da0d0604bf59aeb4a895df43..cafba4e8d67545bd210477230b9682fe86620e23 100644 --- a/gcc/testsuite/gcc.target/arm/fpscr.c +++ b/gcc/testsuite/gcc.target/arm/fpscr.c @@ -1,9 +1,9 @@ /* Test the fpscr builtins. */ /* { dg-do compile } */ -/* { dg-require-effective-target arm_fp_ok } */ +/* { dg-require-effective-target arm_vfp_ok } */ /* { dg-skip-if "need fp instructions" { *-*-* } { "-mfloat-abi=soft" } { "" } } */ -/* { dg-add-options arm_fp } */ +/* { dg-options "-mfpu=vfp -mfloat-abi=softfp" } */ void test_fpscr ()