[Darwin/PR49992,2/2] remove ranlib special-casing from the darwin port.

As per the PR audit trail, there is no reason to retain this in the  
building of GCC.

As for its use as a general option in tool-builds;
With current darwin toolsets it has the potential to cause issues when  
using convenience libs containing common.
OK for trunk?
Iain

gcc/ada:

	PR target/49992
	* mlib-tgt-specific-darwin.adb: Remove ranlib special case.
	* gcc-interface/Makefile.in (darwin): Likewise.

On 14 Oct 2011, at 10:37, Iain Sandoe wrote:

> As per the PR audit trail, there is no reason to retain this in the  
> building of GCC.
>
> As for its use as a general option in tool-builds;
> With current darwin toolsets it has the potential to cause issues  
> when using convenience libs containing common.
> OK for trunk?
> Iain
>
> gcc/ada:
>
> 	PR target/49992
> 	* mlib-tgt-specific-darwin.adb: Remove ranlib special case.
> 	* gcc-interface/Makefile.in (darwin): Likewise.
> 	
>
> Index: gcc/ada/mlib-tgt-specific-darwin.adb
> ===================================================================
> --- gcc/ada/mlib-tgt-specific-darwin.adb	(revision 179962)
> +++ gcc/ada/mlib-tgt-specific-darwin.adb	(working copy)
> @@ -68,7 +68,7 @@ package body MLib.Tgt.Specific is
>
>    function Archive_Indexer_Options return String_List_Access is
>    begin
> -      return new String_List'(1 => new String'("-c"));
> +      return new String_List'(1 => new String'(""));
>    end Archive_Indexer_Options;
>
>    ---------------------------
> Index: gcc/ada/gcc-interface/Makefile.in
> ===================================================================
> --- gcc/ada/gcc-interface/Makefile.in	(revision 179962)
> +++ gcc/ada/gcc-interface/Makefile.in	(working copy)
> @@ -2179,7 +2179,6 @@ ifeq ($(strip $(filter-out darwin%,$(osys))),)
>
>   EH_MECHANISM=-gcc
>   GNATLIB_SHARED = gnatlib-shared-darwin
> -  RANLIB = ranlib -c
>   GMEM_LIB = gmemlib
>   LIBRARY_VERSION := $(LIB_VERSION)
>   soext = .dylib
>
>

This is unreviewed for 2 weeks.

I am sure that this issue will be affecting Ada on Darwin10/11 with  
the latest toolchains.

It might be subtle without LTO - OTOH when LTO is engaged it breaks  
things completely.


On 22 Oct 2011, at 08:37, Iain Sandoe wrote:

>
> On 14 Oct 2011, at 10:37, Iain Sandoe wrote:
>
>> As per the PR audit trail, there is no reason to retain this in the  
>> building of GCC.
>>
>> As for its use as a general option in tool-builds;
>> With current darwin toolsets it has the potential to cause issues  
>> when using convenience libs containing common.
>> OK for trunk?
>> Iain
>>
>> gcc/ada:
>>
>> 	PR target/49992
>> 	* mlib-tgt-specific-darwin.adb: Remove ranlib special case.
>> 	* gcc-interface/Makefile.in (darwin): Likewise.
>> 	
>>
>> Index: gcc/ada/mlib-tgt-specific-darwin.adb
>> ===================================================================
>> --- gcc/ada/mlib-tgt-specific-darwin.adb	(revision 179962)
>> +++ gcc/ada/mlib-tgt-specific-darwin.adb	(working copy)
>> @@ -68,7 +68,7 @@ package body MLib.Tgt.Specific is
>>
>>   function Archive_Indexer_Options return String_List_Access is
>>   begin
>> -      return new String_List'(1 => new String'("-c"));
>> +      return new String_List'(1 => new String'(""));
>>   end Archive_Indexer_Options;
>>
>>   ---------------------------
>> Index: gcc/ada/gcc-interface/Makefile.in
>> ===================================================================
>> --- gcc/ada/gcc-interface/Makefile.in	(revision 179962)
>> +++ gcc/ada/gcc-interface/Makefile.in	(working copy)
>> @@ -2179,7 +2179,6 @@ ifeq ($(strip $(filter-out darwin%,$(osys))),)
>>
>>  EH_MECHANISM=-gcc
>>  GNATLIB_SHARED = gnatlib-shared-darwin
>> -  RANLIB = ranlib -c
>>  GMEM_LIB = gmemlib
>>  LIBRARY_VERSION := $(LIB_VERSION)
>>  soext = .dylib
>>
>>
>

On Oct 28, 2011, at 8:41 AM, Iain Sandoe wrote:
> This is unreviewed for 2 weeks.

Odd, usually the Ada people are fairly responsive.  If they want me to weigh in, I approve of the concept behind the work.

Le 28/10/2011 17:41, Iain Sandoe a écrit :
> This is unreviewed for 2 weeks.
>
> I am sure that this issue will be affecting Ada on Darwin10/11 with 
> the latest toolchains.

It's actually under discussion and is pretty subtle, so delicate. Thanks 
for your patience.

Arno

The new version of the patch as suggested by Tristan is OK to commit,
thanks.

Arno