From patchwork Thu Nov 21 09:11:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 293046 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1AC2F2C008F for ; Thu, 21 Nov 2013 20:13:27 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=izzwYTGuwGLIaVrC fEczvdFAvYpQobYg/nEBdhmUk1x8gHkSoqu1YnaJrOoiZZGo4aoEwkwzsHJ2JygS OKecO8NJ/LsnaJRtJWvd7vkTLucDcGRRvWyCn6IhJyEnIvYSm+xOt9jPUjw9GC6c OtzNqUo6NjH+aJifRzlPiIgHsFc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=Ei2pw+220qpau8YGJcVoIM r0zsY=; b=Z9sgMh5vaRCodPoqZvaLjxoiMZdU/yiLeGcfF0hte9WB4seED+za/V 8O9L3X6U5A757D767KEd8a2z7zjBhG93cwKSRzWLcIncX/ep+W2K4mR8bm1mPeGJ utJU1XtabP+xu97/DGIFu7OHDr5ftORNQa9dyAtQZkUqSMnPTExtM= Received: (qmail 5257 invoked by alias); 21 Nov 2013 09:13:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5244 invoked by uid 89); 21 Nov 2013 09:13:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL, BAYES_50, RDNS_NONE, URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from Unknown (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Nov 2013 09:13:13 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 083B626A85AC for ; Thu, 21 Nov 2013 10:13:05 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XIwhhGCAQn0L for ; Thu, 21 Nov 2013 10:13:04 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id DD9A126A8530 for ; Thu, 21 Nov 2013 10:13:04 +0100 (CET) From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: Fix couple of ACATS failures Date: Thu, 21 Nov 2013 10:11:29 +0100 Message-ID: <3866700.MMJZAb1hG8@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.29-desktop; KDE/4.7.2; x86_64; ; ) MIME-Version: 1.0 This fixes the couple of ACATS failures === acats tests === FAIL: c45531j FAIL: c45531l === acats Summary === # of expected passes 2318 # of unexpected failures 2 introduced by Jeff's latest threading patches. The Tree-SSA tail merging pass was wrongly spotting basic blocks as duplicate but one of them had a statement that could throw and the other hadn't. Tested on x86_64-suse-linux, applied on the mainline as obvious. 2013-11-21 Eric Botcazou * tree-ssa-tail-merge.c (stmt_local_def): Return false if the statement could throw. Index: tree-ssa-tail-merge.c =================================================================== --- tree-ssa-tail-merge.c (revision 205090) +++ tree-ssa-tail-merge.c (working copy) @@ -309,6 +309,7 @@ stmt_local_def (gimple stmt) def_operand_p def_p; if (gimple_has_side_effects (stmt) + || stmt_could_throw_p (stmt) || gimple_vdef (stmt) != NULL_TREE) return false;