From patchwork Mon May 27 08:32:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 1105686 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-501704-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="jpJjgUAC"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45C9GL2v1fz9s1c for ; Mon, 27 May 2019 18:32:58 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=LXYAybDFh6vnp5j0 brUVtKsRLylop1r8ntSO8NjD4Q1D0DxANUtN786AeLq/cuR4u1nVrCVgMvTydYFc hWQyxV96rlw3fUIor9+Ta1XJvnvDJEV0qhHlV7ApEJ/cK3eXWiIxXNuFACdLjHi/ FSoOioJuBkFL77QXSgYz+9dwDPg= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=Vm5zf//f5c0PyyqoirwnOq dGq/8=; b=jpJjgUAC1kIlzmzh5kLzSYJGXhFYFOarLHLMvBIfJMt/7PphggB4lc /Dr1ciFM9GVCuoogDavKI/SUB90xrFsb4zhmdnG2mVRNbjNp69MPwxwZ7OnI4ieg 8zkR1wx5PPFkKwC+9tCBPF6OCiRUMNNYg2cbc07+GdvnYe1aw6Lo0= Received: (qmail 67828 invoked by alias); 27 May 2019 08:32:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 67817 invoked by uid 89); 27 May 2019 08:32:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=sk:dw_op_g, sk:DW_OP_G X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 May 2019 08:32:49 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 21EEE81380 for ; Mon, 27 May 2019 10:32:47 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ITDYC_oEIYpC for ; Mon, 27 May 2019 10:32:47 +0200 (CEST) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 028F98137F for ; Mon, 27 May 2019 10:32:47 +0200 (CEST) From: Eric Botcazou To: gcc-patches@gcc.gnu.org Subject: [patch] Fix ICE in resolve_args_picking_1 with -gsplit-dwarf Date: Mon, 27 May 2019 10:32:20 +0200 Message-ID: <3530053.ohGVArVget@polaris> MIME-Version: 1.0 The function simply doesn't handle the new location expression opcodes coming from DebugFission (https://gcc.gnu.org/wiki/DebugFission). Fixed by making it handle them like DW_OP_addr and DW_OP_const*. OK for mainline and the active branches (it's a regression from GCC 5)? 2019-05-27 Eric Botcazou * dwarf2out.c (resolve_args_picking_1): Deal with DW_OP_GNU_addr_index and DW_OP_GNU_const_index opcodes. 2019-05-27 Eric Botcazou * gnat.dg/specs/array4.ads: New test. Index: dwarf2out.c =================================================================== --- dwarf2out.c (revision 271106) +++ dwarf2out.c (working copy) @@ -17906,6 +17906,8 @@ resolve_args_picking_1 (dw_loc_descr_ref case DW_OP_push_object_address: case DW_OP_call_frame_cfa: case DW_OP_GNU_variable_value: + case DW_OP_GNU_addr_index: + case DW_OP_GNU_const_index: ++frame_offset_; break;