From patchwork Wed May 24 14:16:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 766493 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wXvb10yrBz9sNj for ; Thu, 25 May 2017 00:16:28 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="XjIuMrBl"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=TpheFGGUNCEtq6PMlbC3x9d1mipfxuO5oWNCq0HZpew9zfs3wE aGiRPuxpuyEfIicWMFBxNYF0E0MWzcO6q2K3U4EJSNGMfAdkveV2BxQx62ZcSt26 DSLkryAzAiFwaO8Gy3laC5c2Q2aePseqItkzo0iyWcG0DcrJmjBcf/AdI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=9nDzimB06S5rSpS97pPZPyTSw1Q=; b=XjIuMrBlm1wY2n1NEzEA 3mu3Sg+tRlH14RT9ObkG4lKJlc+8Z503n/ZGWxS/wswCkomqgGHfdlFGqSPdaY5M Q9PdP4p52TiPHpJXNwYpXLeLVvcGST7VT6JENkdv46A4XlV4MPEUhRK5Xe/n9rZO hyRq68dXzo/22TjCl+KpBHo= Received: (qmail 94212 invoked by alias); 24 May 2017 14:16:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 94195 invoked by uid 89); 24 May 2017 14:16:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS, URIBL_RED autolearn=ham version=3.3.2 spammy= X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 May 2017 14:16:15 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1dDX5F-0001C8-2U from Tom_deVries@mentor.com for gcc-patches@gcc.gnu.org; Wed, 24 May 2017 07:16:17 -0700 Received: from [127.0.0.1] (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Wed, 24 May 2017 15:16:11 +0100 To: GCC Patches From: Tom de Vries Subject: [testsuite, committed] Reinstate absolute line number in gcc.dg/cpp/19940712-1.c Message-ID: <31337d7a-06d1-cfbe-0bea-ee21dc399a65@mentor.com> Date: Wed, 24 May 2017 16:16:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) Hi, the line number refers to a line in a header file, so we want to keep that absolute. [ The absolute line numbers that we want to replace are the ones that start failing once we add a line at the start of the file. If an absolute line number refers to a header file, and we add a line at the start of the including file, the test won't start to fail. However, if we rewrite that line number to a relative one, and add a line at the start of the including file, the test will start to fail. ] Committed. Thanks, - Tom Reinstate absolute line number in gcc.dg/cpp/19940712-1.c 2017-05-24 Tom de Vries * gcc.dg/cpp/19940712-1.c: Reinstate absolute line number. --- gcc/testsuite/gcc.dg/cpp/19940712-1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/cpp/19940712-1.c b/gcc/testsuite/gcc.dg/cpp/19940712-1.c index 7fd9b15..a79b2f5 100644 --- a/gcc/testsuite/gcc.dg/cpp/19940712-1.c +++ b/gcc/testsuite/gcc.dg/cpp/19940712-1.c @@ -2,7 +2,7 @@ /* PR 4713 */ /* dg.exp doesn't read the header files for magic comments. */ -/* { dg-error "unterminated comment" "" { target *-*-* } .-1 } */ +/* { dg-error "unterminated comment" "" { target *-*-* } 4 } */ /* { dg-error "unterminated comment" "header error" { target *-*-* } 8 } */ #include "19940712-1.h"