| Message ID | 2e7c29c1-0ae0-484d-a227-6a8d5d7998d9@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Binutils] AArch64: Enable Debug (FEAT_DEBUGv8p9) extension | expand |
Hey, On 11/24/2023 8:42 AM, Saurabh Jha wrote: > Hey, > > > This patch enables FEAT_DEBUGv8p9 extension for AArch64 and adds its > system registers. FEAT_DEBUGv8p9 is default from Armv8.9-A Architecture. > > > Did regression testing for aarch64-none-elf target and found no > regressions. > > > Ok for master? I don't have commit access so I need someone to commit > on my behalf. > > > Regards, > > Saurabh This patch was incorrectly sent to this mailing list. It has now been sent to the correct one. Please ignore it and apologies for the confusion. Regards, Saurabh
diff --git a/gas/testsuite/gas/aarch64/armv8_9-a-sysregs-bad.l b/gas/testsuite/gas/aarch64/armv8_9-a-sysregs-bad.l index 71ec06e3cb4..7fa3ca1d08f 100644 --- a/gas/testsuite/gas/aarch64/armv8_9-a-sysregs-bad.l +++ b/gas/testsuite/gas/aarch64/armv8_9-a-sysregs-bad.l @@ -77,3 +77,5 @@ .*: Error: selected processor does not support system register name 'tcr2_el1' .*: Error: selected processor does not support system register name 'tcr2_el12' .*: Error: selected processor does not support system register name 'tcr2_el2' +.*: Error: selected processor does not support system register name 'mdselr_el1' +.*: Error: selected processor does not support system register name 'mdselr_el1' diff --git a/gas/testsuite/gas/aarch64/armv8_9-a-sysregs.d b/gas/testsuite/gas/aarch64/armv8_9-a-sysregs.d index ea4cc867ec3..5fc9d807569 100644 --- a/gas/testsuite/gas/aarch64/armv8_9-a-sysregs.d +++ b/gas/testsuite/gas/aarch64/armv8_9-a-sysregs.d @@ -84,3 +84,5 @@ Disassembly of section \.text: .*: d5182060 msr tcr2_el1, x0 .*: d51d2060 msr tcr2_el12, x0 .*: d51c2060 msr tcr2_el2, x0 +.*: d5300440 mrs x0, mdselr_el1 +.*: d5100440 msr mdselr_el1, x0 \ No newline at end of file diff --git a/gas/testsuite/gas/aarch64/armv8_9-a-sysregs.s b/gas/testsuite/gas/aarch64/armv8_9-a-sysregs.s index 2768c268690..ffd86bced83 100644 --- a/gas/testsuite/gas/aarch64/armv8_9-a-sysregs.s +++ b/gas/testsuite/gas/aarch64/armv8_9-a-sysregs.s @@ -98,3 +98,6 @@ msr tcr2_el1, x0 msr tcr2_el12, x0 msr tcr2_el2, x0 + + mrs x0, MDSELR_EL1 + msr MDSELR_EL1, x0 diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h index 632338318b6..49d9682b02b 100644 --- a/include/opcode/aarch64.h +++ b/include/opcode/aarch64.h @@ -197,6 +197,8 @@ enum aarch64_feature_bit { AARCH64_FEATURE_S2POE, /* Extension to Translation Control Registers. */ AARCH64_FEATURE_TCR2, + /* Armv8.9-A/Armv9.4-A architecture Debug extension. */ + AARCH64_FEATURE_DEBUGv8p9, AARCH64_NUM_FEATURES }; @@ -267,6 +269,7 @@ enum aarch64_feature_bit { | AARCH64_FEATBIT (X, S1POE) \ | AARCH64_FEATBIT (X, S2POE) \ | AARCH64_FEATBIT (X, TCR2) \ + | AARCH64_FEATBIT (X, DEBUGv8p9) \ ) #define AARCH64_ARCH_V9A_FEATURES(X) (AARCH64_FEATBIT (X, V9A) \ diff --git a/opcodes/aarch64-sys-regs.def b/opcodes/aarch64-sys-regs.def index 0f647efca7e..f7ad09b8ad8 100644 --- a/opcodes/aarch64-sys-regs.def +++ b/opcodes/aarch64-sys-regs.def @@ -570,6 +570,7 @@ SYSREG ("mdcr_el3", CPENC (3,6,1,3,1), 0, AARCH64_NO_FEATURES) SYSREG ("mdrar_el1", CPENC (2,0,1,0,0), F_REG_READ, AARCH64_NO_FEATURES) SYSREG ("mdscr_el1", CPENC (2,0,0,2,2), 0, AARCH64_NO_FEATURES) + SYSREG ("mdselr_el1", CPENC (2,0,0,4,2), F_ARCHEXT, AARCH64_FEATURE (DEBUGv8p9)) SYSREG ("mecid_a0_el2", CPENC (3,4,10,8,1), 0, AARCH64_NO_FEATURES) SYSREG ("mecid_a1_el2", CPENC (3,4,10,8,3), 0, AARCH64_NO_FEATURES) SYSREG ("mecid_p0_el2", CPENC (3,4,10,8,0), 0, AARCH64_NO_FEATURES)
Hey, This patch enables FEAT_DEBUGv8p9 extension for AArch64 and adds its system registers. FEAT_DEBUGv8p9 is default from Armv8.9-A Architecture. Did regression testing for aarch64-none-elf target and found no regressions. Ok for master? I don't have commit access so I need someone to commit on my behalf. Regards, Saurabh From 5600438d1fb31cc9d0135b92dfe792906e9fac73 Mon Sep 17 00:00:00 2001 From: Saurabh Jha <saujha01@e130340.arm.com> Date: Tue, 21 Nov 2023 09:50:35 +0000 Subject: [PATCH] Enable Debug (DEBUGv8p9) extension for AArch64 --- gas/testsuite/gas/aarch64/armv8_9-a-sysregs-bad.l | 2 ++ gas/testsuite/gas/aarch64/armv8_9-a-sysregs.d | 2 ++ gas/testsuite/gas/aarch64/armv8_9-a-sysregs.s | 3 +++ include/opcode/aarch64.h | 3 +++ opcodes/aarch64-sys-regs.def | 1 + 5 files changed, 11 insertions(+)