diff mbox series

[11,COMMITTED] Disable poor value processing in ranger cache.

Message ID 2dce94ec-fe4e-b7cb-2c49-aeb31f072fec@redhat.com
State New
Headers show
Series [11,COMMITTED] Disable poor value processing in ranger cache. | expand

Commit Message

Andrew MacLeod July 14, 2021, 10:08 p.m. UTC 
We have disabled the poor value cache in trunk as not providing enough 
benefit for the cost. do the same in gcc 11.

Bootstrapped on x86_64-pc-linux-gnu with no regressions.  pushed.

Andrew
diff mbox series

Patch

From 86534c07a390e240ffea51653945de85df7a3632 Mon Sep 17 00:00:00 2001
From: Andrew MacLeod <amacleod@redhat.com>
Date: Wed, 23 Jun 2021 12:55:14 -0400
Subject: [PATCH 5/8] Disable poor value processing in ranger cache.

	* gimple-range-cache.cc (ranger_cache::push_poor_value): Disable
	poor value processing.
---
 gcc/gimple-range-cache.cc | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/gcc/gimple-range-cache.cc b/gcc/gimple-range-cache.cc
index bc4b557b493..068905d4774 100644
--- a/gcc/gimple-range-cache.cc
+++ b/gcc/gimple-range-cache.cc
@@ -846,20 +846,9 @@  ranger_cache::register_dependency (tree name, tree dep)
 bool
 ranger_cache::push_poor_value (basic_block bb, tree name)
 {
-  if (m_poor_value_list.length ())
-    {
-      // Don't push anything else to the same block.  If there are multiple 
-      // things required, another request will come during a later evaluation
-      // and this prevents oscillation building uneccessary depth.
-      if ((m_poor_value_list.last ()).bb == bb)
-	return false;
-    }
-
-  struct update_record rec;
-  rec.bb = bb;
-  rec.calc = name;
-  m_poor_value_list.safe_push (rec);
-  return true;
+  // Disable poor value processing for GCC 11.  It has been disabled in GCC 12
+  // as adding too much churn/compile time for too little benefit.
+  return false;
 }
 
 //  Provide lookup for the gori-computes class to access the best known range
-- 
2.17.2