From patchwork Wed Jun 1 14:53:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Botcazou X-Patchwork-Id: 628697 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rKYK814hCz9sxb for ; Thu, 2 Jun 2016 00:54:03 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=ofyhsuJN; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; q=dns; s= default; b=K2vMW/CPgeyKqrUUDW+b87nVpXfIuVJ/2GQb5Fwa+C8vAzAQbwWgq AzAqqHqqERaLseUmJhQLgmuufz5XCzBf8CHavPpbbgYEIHBgjOeOrmkl7f+9nqkQ OwslXNSz/2qk8u/PKyVq9dge9wTUDyzZGIaZ3KnINmYfHQEKDvdl2w= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=default; bh=qsdcK1muGOCtn8TxctL/kNmO4L0=; b=ofyhsuJNEGM9qx2sIR6CC+aD/ouY Ldb1PL5NYwHLl3foteYEo9WBWRGKJj/e38A8bhKXDWVZ2FWVQPZswuiYkjynGzC3 MndR/xRH7HqcgJWHKqfLD1/eSintTh9SIQs1YB0Mp2r72vvuGFrUblP3tznuUydl I2hU0DJ9w+uzLS8= Received: (qmail 7015 invoked by alias); 1 Jun 2016 14:53:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6998 invoked by uid 89); 1 Jun 2016 14:53:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=loo, H*MI:sk:3369303, H*MI:sk:Dv5TfbC, H*i:sk:Dv5TfbC X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 01 Jun 2016 14:53:52 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 9ED108132C; Wed, 1 Jun 2016 16:53:49 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id baEkIDb9ZXwi; Wed, 1 Jun 2016 16:53:49 +0200 (CEST) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 7B633812DB; Wed, 1 Jun 2016 16:53:49 +0200 (CEST) From: Eric Botcazou To: Ilya Enkovich Cc: gcc-patches@gcc.gnu.org, Richard Biener Subject: Re: [patch] Fix segfault in vectorizer Date: Wed, 01 Jun 2016 16:53:48 +0200 Message-ID: <2792358.zmlo7uQNnU@polaris> User-Agent: KMail/4.14.10 (Linux/3.16.7-35-desktop; KDE/4.14.9; x86_64; ; ) In-Reply-To: References: <3369303.TJyCcmduk2@polaris> MIME-Version: 1.0 > Surely any missing vectype for a statement due to this delay is a bug. I > didn't notice STMT_VINFO_LIVE_P should be checked in addition to > STMT_VINFO_RELEVANT_P. In fact this brings back PR tree-opt/68327 on the 6 branch: (gdb) frame 0 #0 internal_error (gmsgid=gmsgid@entry=0x170cd58 "in %s, at %s:%d") at /home/eric/svn/gcc-6-branch/gcc/diagnostic.c:1251 1251 { (gdb) frame 1 #1 0x000000000101c5c4 in fancy_abort (file=, line=, function=) at /home/eric/svn/gcc-6-branch/gcc/diagnostic.c:1327 1327 internal_error ("in %s, at %s:%d", function, trim_filename (file), line); (gdb) frame 2 #2 0x0000000000b75f5e in vect_is_simple_use (operand=0x7ffff6c3f9d8, vinfo=0x1ddb690, def_stmt=0x7fffffffd888, dt=0x7fffffffd86c, vectype=0x7fffffffd878) at /home/eric/svn/gcc-6-branch/gcc/tree-vect-stmts.c:8763 8763 gcc_assert (*vectype != NULL_TREE); (gdb) p debug_gimple_stmt(*def_stmt) b.0_2 = PHI $5 = void because we don't compute STMT_VINFO_VECTYPE for live PHI statement, but only for relevant ones, so we need this too: Index: tree-vect-loop.c =================================================================== --- tree-vect-loop.c (revision 236983) +++ tree-vect-loop.c (working copy) @@ -216,7 +216,8 @@ vect_determine_vectorization_factor (loo gcc_assert (stmt_info); - if (STMT_VINFO_RELEVANT_P (stmt_info)) + if (STMT_VINFO_RELEVANT_P (stmt_info) + || STMT_VINFO_LIVE_P (stmt_info)) { gcc_assert (!STMT_VINFO_VECTYPE (stmt_info)); scalar_type = TREE_TYPE (PHI_RESULT (phi));