Message ID | 2636777.qFgsGORUrM@laptop1.gw.ume.nu |
---|---|
State | New |
Headers | show |
Any chance of this patch getting a review and commit soon so that it can go into gcc trunk and gcc-4_8-branch? Jack On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote: > This patch readd TARGET_H that was removed with revision 188166 > IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that > did have TARGET_H before it was removed and it was not added to IPA_PROP_H or > PLUGIN_HEADERS. See the bug for more info. > > /Magnus > > gcc: > > 2013-03-30 Magnus Granberg <zorry@gentoo.org> > > PR plugins/56754 > * Makefile.in (PLUGIN_HEADERS): Add TARGET_H > > > --- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100 > +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100 > @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $ > $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \ > cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \ > $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \ > - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h > + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h > > # generate the 'build fragment' b-header-vars > s-header-vars: Makefile
On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote: > This patch readd TARGET_H that was removed with revision 188166 > IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that > did have TARGET_H before it was removed and it was not added to IPA_PROP_H or > PLUGIN_HEADERS. See the bug for more info. > 2013-03-30 Magnus Granberg <zorry@gentoo.org> Two spaces before <, instead of just one. > > PR plugins/56754 > * Makefile.in (PLUGIN_HEADERS): Add TARGET_H Missing dot at the end of line, plus it should be $(TARGET_H) instead of TARGET_H. Where has it been tested? > --- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100 > +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100 > @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $ > $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \ > cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \ > $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \ > - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h > + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h > > # generate the 'build fragment' b-header-vars > s-header-vars: Makefile Jakub
On Tue, May 21, 2013 at 05:09:14PM +0200, Jakub Jelinek wrote: > On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote: > > This patch readd TARGET_H that was removed with revision 188166 > > IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that > > did have TARGET_H before it was removed and it was not added to IPA_PROP_H or > > PLUGIN_HEADERS. See the bug for more info. > > > 2013-03-30 Magnus Granberg <zorry@gentoo.org> > > Two spaces before <, instead of just one. > > > > PR plugins/56754 > > * Makefile.in (PLUGIN_HEADERS): Add TARGET_H > > Missing dot at the end of line, plus it should be $(TARGET_H) > instead of TARGET_H. > > Where has it been tested? This has been tested on i386-apple-darwin10, x86_64-apple-darwin10, x86_64-apple-darwin11 and x86_64-apple-darwin12. The resulting gcc 4.8.1svn builds have been used to build dragonegg trunk against gcc 4.8.1svn on x86_64-apple-darwin12. > > > --- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100 > > +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100 > > @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $ > > $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \ > > cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \ > > $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \ > > - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h > > + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h > > > > # generate the 'build fragment' b-header-vars > > s-header-vars: Makefile > > > Jakub
Hi Jakub, I actually committed this patch to mainline earlier today, as it is trivial, enables my own plugin (dragonegg) to compile against gcc-4.8, and according to the PR makes some other plugins work with gcc-4.8 too. I will backport it to the gcc-4.8 branch if no-one objects. But maybe you are objecting? On 21/05/13 17:09, Jakub Jelinek wrote: > On Sat, Mar 30, 2013 at 03:17:59PM +0100, Magnus Granberg wrote: >> This patch readd TARGET_H that was removed with revision 188166 >> IPA_PROP_H is in use by PLUGIN_HEADERS and did depend on GIMPLE_H that >> did have TARGET_H before it was removed and it was not added to IPA_PROP_H or >> PLUGIN_HEADERS. See the bug for more info. > >> 2013-03-30 Magnus Granberg <zorry@gentoo.org> > > Two spaces before <, instead of just one. I had corrected this one already in the version I committed. >> >> PR plugins/56754 >> * Makefile.in (PLUGIN_HEADERS): Add TARGET_H > > Missing dot at the end of line, plus it should be $(TARGET_H) > instead of TARGET_H. I missed these however. I will correct the changelog if you are otherwise OK with the commit. > > Where has it been tested? In addition to what Jack mentioned, x86-64 ubuntu 13.04. Ciao, Duncan. > >> --- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100 >> +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100 >> @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $ >> $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \ >> cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \ >> $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \ >> - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h >> + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h >> >> # generate the 'build fragment' b-header-vars >> s-header-vars: Makefile > > > Jakub >
--- a/gcc/Makefile.in 2013-02-08 10:07:49.000000000 +0100 +++ b/gcc/Makefile.in 2013-03-28 03:43:53.343390945 +0100 @@ -4597,7 +4597,7 @@ PLUGIN_HEADERS = $(TREE_H) $(CONFIG_H) $ $(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \ cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \ $(GIMPLE_PRETTY_PRINT_H) realmpfr.h \ - $(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h + $(IPA_PROP_H) $(TARGET_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h # generate the 'build fragment' b-header-vars s-header-vars: Makefile