diff mbox series

Fortran: intrinsic.texi add missing arg to FINDLOC (was: FINDLOC documentation at https://gcc.gnu.org/onlinedocs/gfortran/FINDLOC.html)

Message ID 2224af35-17cf-3be5-3c89-66c125db78a0@net-b.de
State New
Headers show
Series Fortran: intrinsic.texi add missing arg to FINDLOC (was: FINDLOC documentation at https://gcc.gnu.org/onlinedocs/gfortran/FINDLOC.html) | expand

Commit Message

Tobias Burnus Feb. 9, 2021, 9:18 p.m. UTC 
Hi Kay, hi all,

On 09.02.21 21:41, Kay Diederichs wrote:
> the above link does not document the optional MASK argument. Could somebody fix this, please?
Thanks for the comment.

Findloc's mask argument is documented in the text ("If @var{MASK} is 
present, only the elements for which @var{MASK} is @code{.TRUE.} are 
considered.") – but missing from the argument table. Thus, the attached 
patch should be sufficient, shouldn't it?

I intent commit it as obvious, unless there are comments.

Tobias

Comments

Thomas Koenig Feb. 9, 2021, 9:54 p.m. UTC | #1 
Hi Tobias,

> I intent commit it as obvious, unless there are comments.

Just one nit: MASK does not have to be an array, it can
also be a scalar. It just has to be conformable.

OK with that change.

Best regards

	Thomas
Tobias Burnus Feb. 9, 2021, 10:13 p.m. UTC | #2 
Hi Thomas,

On 09.02.21 22:54, Thomas Koenig via Fortran wrote:
> Just one nit: MASK does not have to be an array, it can
> also be a scalar. It just has to be conformable.

Well spotted. However, that also applies to {MAX,MIN}{LOC,VAL}. Hence, I 
updated those as well.

I will commit the patch tomorrow.

Thanks,

Tobias
diff mbox series

Patch

Fortran: intrinsic.texi add missing arg to FINDLOC

gcc/fortran/ChangeLog:

	* intrinsic.texi (FINDLOC): Add 'MASK' to argument table.

diff --git a/gcc/fortran/intrinsic.texi b/gcc/fortran/intrinsic.texi
index 63416bce7fd..4a5172a835c 100644
--- a/gcc/fortran/intrinsic.texi
+++ b/gcc/fortran/intrinsic.texi
@@ -6188,6 +6188,8 @@  conformance with @var{ARRAY}.
 @item @var{DIM} @tab (Optional) Shall be a scalar of type
 @code{INTEGER}, with a value between one and the rank of @var{ARRAY},
 inclusive.  It may not be an optional dummy argument.
+@item @var{MASK} @tab (Optional) Shall be an array of type @code{LOGICAL},
+and conformable with @var{ARRAY}.
 @item @var{KIND} @tab (Optional) An @code{INTEGER} initialization
 expression indicating the kind parameter of the result.
 @item @var{BACK} @tab (Optional) A scalar of type @code{LOGICAL}.