diff mbox series

tree-optimization/115197 - fix ICE w/ constant in LC PHI and loop distribution

Message ID 20240523134502.A31683865488@sourceware.org
State New
Headers show
Series tree-optimization/115197 - fix ICE w/ constant in LC PHI and loop distribution | expand

Commit Message

Richard Biener May 23, 2024, 1:44 p.m. UTC
Forgot a check for an SSA name before trying to replace a PHI arg with
its current definition.

Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.

	PR tree-optimization/115197
	* tree-loop-distribution.cc (copy_loop_before): Constant PHI
	args remain the same.

	* gcc.dg/pr115197.c: New testcase.
---
 gcc/testsuite/gcc.dg/pr115197.c | 14 ++++++++++++++
 gcc/tree-loop-distribution.cc   |  7 +++++--
 2 files changed, 19 insertions(+), 2 deletions(-)
 create mode 100644 gcc/testsuite/gcc.dg/pr115197.c
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/pr115197.c b/gcc/testsuite/gcc.dg/pr115197.c
new file mode 100644
index 00000000000..00d674b3bd9
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr115197.c
@@ -0,0 +1,14 @@ 
+/* { dg-do compile } */
+/* { dg-options "-O1 -fno-tree-scev-cprop -ftree-pre -ftree-loop-distribute-patterns" } */
+
+int a, b[2], c, d, e, f[2];
+int main() {
+  while (a)
+    if (d) {
+      if (e)
+        return 0;
+      for (; c; c++)
+        f[c] = 0 < (b[c] = ~(f[c + 1] < a));
+    }
+  return 0;
+}
diff --git a/gcc/tree-loop-distribution.cc b/gcc/tree-loop-distribution.cc
index 668dc420449..4d1ed234fcb 100644
--- a/gcc/tree-loop-distribution.cc
+++ b/gcc/tree-loop-distribution.cc
@@ -977,8 +977,11 @@  copy_loop_before (class loop *loop, bool redirect_lc_phi_defs)
 	  if (virtual_operand_p (gimple_phi_result (phi)))
 	    continue;
 	  use_operand_p use_p = PHI_ARG_DEF_PTR_FROM_EDGE (phi, exit);
-	  tree new_def = get_current_def (USE_FROM_PTR (use_p));
-	  SET_USE (use_p, new_def);
+	  if (TREE_CODE (USE_FROM_PTR (use_p)) == SSA_NAME)
+	    {
+	      tree new_def = get_current_def (USE_FROM_PTR (use_p));
+	      SET_USE (use_p, new_def);
+	    }
 	}
     }