From patchwork Tue May 7 11:20:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1932426 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=hTnlv4G3; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pVkaLoUJ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=zm+KON+c; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=bpmLFOP/; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VYbSb5zBMz1ydW for ; Tue, 7 May 2024 21:21:19 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 16BEF384AB6E for ; Tue, 7 May 2024 11:21:18 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 367813858C35 for ; Tue, 7 May 2024 11:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 367813858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 367813858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715080858; cv=none; b=mMZ18a1RzdTxiepRj0t1hgsdHl22BW9M+TyHU5N2Kggj2URasx1kYU06EXJwZKv16lbxGkZGyS6hmJ7SNAEuWvHnhcik207fcXhJd8V2Wfi/mnUTgOcFBleZmVu3tLbL8KzW3a+pkExQMVb377TxRVx0QBN7voBRlXv0XHjaUI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715080858; c=relaxed/simple; bh=idemUVJcNJA2ucDVjXyXHRSi2mcfaBv9XIsdhnOV/1s=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=UgLG8dPsvsS9gcgNm7hM8xDteoyFDxEws6vtXSDAl/6h8/kHgoZj+zjOAOJWRmOlW0Ytj8Zi9qa0DL9ze4Fs/FRrEJR30mz+ALBTJ4/4b4hPo6f7iX22Q/qJoPcky3AJfR6Bobp/SG8rQJ2vPFSbNNnXBWhBCByvW5tWbZB/xkI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E30CF2089D for ; Tue, 7 May 2024 11:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715080856; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=kS2yJlv08WiAARz0kZvHtPxz3MsgwpyJ5BSh72k7SCQ=; b=hTnlv4G3VVPSXr7YKpnltEIK7OlyKMJodNGgUf3rwqGOp0Uy72WkZJc5ZABoh20XjfXGkE Rd3aez68wSX6H1+qZFL33PRY3c2B6nxMb2jAD4wnIJl+0ix5AV4L8GKzisYN8hE4B+iNNd 3RmrYO6MLaP6U3Y5MoyGo0uhFT2tzzg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715080856; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=kS2yJlv08WiAARz0kZvHtPxz3MsgwpyJ5BSh72k7SCQ=; b=pVkaLoUJgH9m/rZZLhBQKAX8KFqfnLbFI2pP/JRDpKP8Ep9Cjaqx0IfH3DBjZ+2LcwMQAP WBQIPvIt7PkTxYAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715080855; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=kS2yJlv08WiAARz0kZvHtPxz3MsgwpyJ5BSh72k7SCQ=; b=zm+KON+cOwH25XeLKCPbn5iQghh9GyCMigZQVuNCfD+Cq+b+GmOMM0GMgQeVR51nw08R0o wr1e1Mo0EVf/xfyG5rwhaw54qFxezrSJCUrxRSGP5exRxP4FjN5U/rWq0J5anhj47jsvVT DiYHbhTuE2pAJGemWW/9PdokW6UKSw4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715080855; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=kS2yJlv08WiAARz0kZvHtPxz3MsgwpyJ5BSh72k7SCQ=; b=bpmLFOP/CZA0ZHbuJJ2rkRubnhO/ValtA6QNfADEZbgE6Qneh0fOUIzzCHgFSeReI2yGOn Guepjg9fJ+9G+2AA== Date: Tue, 7 May 2024 13:20:55 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Remove redundant check MIME-Version: 1.0 X-Spam-Score: 1.28 X-Spamd-Result: default: False [1.28 / 50.00]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-1.00)[-0.995]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_SHORT(-0.08)[-0.397]; BAYES_HAM(-0.05)[59.95%]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; MISSING_XM_UA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_NONE(0.00)[]; MIME_TRACE(0.00)[0:+] X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240507112118.16BEF384AB6E@sourceware.org> operand_equal_p already has checking code to verify the hash is equal, avoid doing that again in gimplify_hasher::equal. Re-bootstrap & regtest running on x86_64-unknown-linux-gnu. * gimplify.cc (gimplify_hasher::equal): Remove redundant checking. --- gcc/gimplify.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/gcc/gimplify.cc b/gcc/gimplify.cc index a6573a498d9..26e96ada4c7 100644 --- a/gcc/gimplify.cc +++ b/gcc/gimplify.cc @@ -19603,9 +19603,5 @@ gimplify_hasher::equal (const elt_t *p1, const elt_t *p2) if (!operand_equal_p (t1, t2, 0)) return false; - /* Only allow them to compare equal if they also hash equal; otherwise - results are nondeterminate, and we fail bootstrap comparison. */ - gcc_checking_assert (hash (p1) == hash (p2)); - return true; }