From patchwork Thu May 2 11:59:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1930603 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qZnLon4c; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=U5lhDVvU; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=qZnLon4c; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=U5lhDVvU; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VVXYj6LBdz1ydT for ; Thu, 2 May 2024 22:00:08 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7246C3858431 for ; Thu, 2 May 2024 12:00:06 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id D12BE3858D33 for ; Thu, 2 May 2024 11:59:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D12BE3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D12BE3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714651190; cv=none; b=kXI3V4NdrOosVf4a37XNhGgVOmTfjsXYMUGT15YviuFJVmIZU7EbmOFg433ney/Zi0QS0dv+E034hPhyhL1QkPxH/Z1l6jPPkXdJT9YgpjkPld798Mn/uR9zwinxx9IYhSBI5VTPySm7mAPSFjTZLqmnJc0cumei125H6RAgxdg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714651190; c=relaxed/simple; bh=VS1eQvfBjvYCVBn7vwUMMQaFMxqpWp5N1jB4hnqJ40Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=Yj+QF1v51nOuJogI3ArDKlRbYXsHiS5PMMZmmOUz8BD3rpdisM8ddppJF9dJ/OTVkMBqURHsoqzKVM7/j5ukeF3i6nDxw0hZ/NOAo6o6LEZlcehZkxcqa4y8xDHO2j2kbW+bLNoJ2bxv0rHa64rsIArpbz+nyfPe7eIyJfcUMeg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.5.241] (unknown [10.168.5.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D1EF11FBF9 for ; Thu, 2 May 2024 11:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714651186; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=m9DpgSUmNFpnRQ9wrBGaDQuV3S31HCn5p58ai9iwHbo=; b=qZnLon4ct5dUdBwrDgPc5feVwFxqLYMpzBb33YmX4uH/XIZIDpyhW/G33sf9cD2nSzy6cA Hif7LaxEs/BxloRox9JgKqsdk7XKTWNv9NHWjFKJt+st0obrZL6GEfN64da/e2NNjawfet dM7tPqZLegFHSaHzGfBBuinXloOKymM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714651186; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=m9DpgSUmNFpnRQ9wrBGaDQuV3S31HCn5p58ai9iwHbo=; b=U5lhDVvUswgSPfktlEv3jWtk6SMpUT30SbrglJCWFcphQHjNcOd6P6U1y1BDijUHGQ6AL5 maX2yde8YOC7PjDg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1714651186; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=m9DpgSUmNFpnRQ9wrBGaDQuV3S31HCn5p58ai9iwHbo=; b=qZnLon4ct5dUdBwrDgPc5feVwFxqLYMpzBb33YmX4uH/XIZIDpyhW/G33sf9cD2nSzy6cA Hif7LaxEs/BxloRox9JgKqsdk7XKTWNv9NHWjFKJt+st0obrZL6GEfN64da/e2NNjawfet dM7tPqZLegFHSaHzGfBBuinXloOKymM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1714651186; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=m9DpgSUmNFpnRQ9wrBGaDQuV3S31HCn5p58ai9iwHbo=; b=U5lhDVvUswgSPfktlEv3jWtk6SMpUT30SbrglJCWFcphQHjNcOd6P6U1y1BDijUHGQ6AL5 maX2yde8YOC7PjDg== Date: Thu, 2 May 2024 13:59:46 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/114921 - _Float16 -> __bf16 isn't noop MIME-Version: 1.0 X-Spam-Score: -1.30 X-Spam-Level: X-Spamd-Result: default: False [-1.30 / 50.00]; BAYES_HAM(-2.54)[97.95%]; MISSING_MID(2.50)[]; NEURAL_HAM_LONG(-0.99)[-0.989]; NEURAL_HAM_SHORT(-0.17)[-0.858]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[] X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240502120006.7246C3858431@sourceware.org> The vectorizer handles a _Float16 to __bf16 conversion through vectorizable_assignment, thinking it's a noop. The following fixes this by making the same-size check stricter, requiring the same vector component mode. Bootstrap & regtest running on x86_64-unknown-linux-gnu. I couldn't manage to produce a meaningful (runtime) testcase. PR tree-optimization/114921 * tree-vect-stmts.cc (vectorizable_assignment): Require same vector component modes for input and output. --- gcc/tree-vect-stmts.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index f8d8636b139..5ec053755a2 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -5961,8 +5961,7 @@ vectorizable_assignment (vec_info *vinfo, || code == VIEW_CONVERT_EXPR) && (!vectype_in || maybe_ne (TYPE_VECTOR_SUBPARTS (vectype_in), nunits) - || maybe_ne (GET_MODE_SIZE (TYPE_MODE (vectype)), - GET_MODE_SIZE (TYPE_MODE (vectype_in))))) + || TYPE_MODE (vectype) != TYPE_MODE (vectype_in))) return false; if (VECTOR_BOOLEAN_TYPE_P (vectype) != VECTOR_BOOLEAN_TYPE_P (vectype_in))