From patchwork Wed Apr 10 05:59:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1921723 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wsUpbiXQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+RqHmkVJ; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wsUpbiXQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+RqHmkVJ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VDsbp2s3Nz1yYB for ; Wed, 10 Apr 2024 15:59:34 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 461F63861013 for ; Wed, 10 Apr 2024 05:59:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 3A1853858D20 for ; Wed, 10 Apr 2024 05:59:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A1853858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3A1853858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712728753; cv=none; b=SPGx4toBr3LOiHXdx2b5lyFpPRywQ1YrGMpr4PJ2smyNZ1tPZNE46r6JsJc8+cIlY67h5JrKTvN6hlnkqoCyK4IridEmTyjcSeUmPQLRoK+tKhNVM6whVQjzgDkyEAIUz12Wdfno3hkncXQ9v+yji35sIdzzCLoQfZsY09JqhWM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712728753; c=relaxed/simple; bh=BOZxFIA3J1cNahpjeisbhZGMVyt2qo/XaAsVBHRzxpQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=xSgc7YDpRM7Ael8QUT6XxbBzzKUZwjNpdXnsvKXzmGoZH1lXtViiyY/sYNoMrgEXNOx2BILaXmCZNC5kp2USKf2vytP8Fbq5wn809qWNNAAxuuSuypHC7k7nnme8c4wO71Hj1iNJr6dEBMpxyKoCZVgiABqq8kUjt4uDS7qSL44= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [10.150.64.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D70733497D for ; Wed, 10 Apr 2024 05:59:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712728748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=61zmgYUP+qAL8hM23qesCiR9oyceAFUv4iZ2qRDNkU4=; b=wsUpbiXQ/DtTHbaYpD+AZhcBFwLZ3wXJZZlKjfuZ7w/5sW/EXkGl/UcrtjtwIblPX9zWcl iN72bNzP/4qiZuRsij12Ed0iF5qZSPvogfvPFrCY+bMPdB4LgaD+82WCyGTM7feXWyqkaS HVvzpn/ftbhPshTNu5HFT8Ds701YY7c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712728748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=61zmgYUP+qAL8hM23qesCiR9oyceAFUv4iZ2qRDNkU4=; b=+RqHmkVJufIdYf7j0eSItXANiaaiKfwKdIIHkkIILgeZLTxUNC5XYZ8sNbTWeudQVAz/8u dM4DexNEKsEovQCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1712728748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=61zmgYUP+qAL8hM23qesCiR9oyceAFUv4iZ2qRDNkU4=; b=wsUpbiXQ/DtTHbaYpD+AZhcBFwLZ3wXJZZlKjfuZ7w/5sW/EXkGl/UcrtjtwIblPX9zWcl iN72bNzP/4qiZuRsij12Ed0iF5qZSPvogfvPFrCY+bMPdB4LgaD+82WCyGTM7feXWyqkaS HVvzpn/ftbhPshTNu5HFT8Ds701YY7c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1712728748; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=61zmgYUP+qAL8hM23qesCiR9oyceAFUv4iZ2qRDNkU4=; b=+RqHmkVJufIdYf7j0eSItXANiaaiKfwKdIIHkkIILgeZLTxUNC5XYZ8sNbTWeudQVAz/8u dM4DexNEKsEovQCg== Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id BBBA213A92 for ; Wed, 10 Apr 2024 05:59:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id S7bpK6wqFmYxNAAAn2gu4w (envelope-from ) for ; Wed, 10 Apr 2024 05:59:08 +0000 Date: Wed, 10 Apr 2024 07:59:00 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Revert "combine: Don't combine if I2 does not change" MIME-Version: 1.0 Message-Id: <20240410055908.BBBA213A92@imap2.dmz-prg2.suse.org> X-Spam-Score: -1.31 X-Spam-Level: X-Spamd-Result: default: False [-1.31 / 50.00]; NEURAL_HAM_LONG(-1.00)[-0.998]; NEURAL_HAM_SHORT(-0.20)[-0.995]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.01)[48.44%]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap2.dmz-prg2.suse.org:helo, imap2.dmz-prg2.suse.org:rdns] X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org This reverts commit 839bc42772ba7af66af3bd16efed4a69511312ae. I have now pushed the temporary reversion of this to resolve the P1 regressions this caused. I'll re-install it on trunk once 14.1 was released (which might be a week or two after stage1 opens). Richard. --- gcc/combine.cc | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/gcc/combine.cc b/gcc/combine.cc index 71c9abc145c..92b8d98e6c1 100644 --- a/gcc/combine.cc +++ b/gcc/combine.cc @@ -4196,17 +4196,6 @@ try_combine (rtx_insn *i3, rtx_insn *i2, rtx_insn *i1, rtx_insn *i0, adjust_for_new_dest (i3); } - /* If I2 didn't change, this is not a combination (but a simplification or - canonicalisation with context), which should not be done here. Doing - it here explodes the algorithm. Don't. */ - if (rtx_equal_p (newi2pat, PATTERN (i2))) - { - if (dump_file) - fprintf (dump_file, "i2 didn't change, not doing this\n"); - undo_all (); - return 0; - } - /* We now know that we can do this combination. Merge the insns and update the status of registers and LOG_LINKS. */