From patchwork Tue Mar 5 11:40:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Ruoyao X-Patchwork-Id: 1908145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xry111.site header.i=@xry111.site header.a=rsa-sha256 header.s=default header.b=IFDN19aO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tptw33Qcxz23cw for ; Tue, 5 Mar 2024 22:42:27 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13074385843E for ; Tue, 5 Mar 2024 11:42:25 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from xry111.site (xry111.site [89.208.246.23]) by sourceware.org (Postfix) with ESMTPS id 72DCE3858CDA; Tue, 5 Mar 2024 11:42:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72DCE3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 72DCE3858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=89.208.246.23 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709638927; cv=none; b=xKzOUFdopn/WUr60ro43QnD3yf0xlF+vCthSGdDMFx6N3RMieJCzi6NZEGU9ualbTWcZmAv6tJNmqnXd94tdiCf8sB+oh7fVPKX5kyhvSHAzj1JksNDRDCXpP+BoukkS8sfYIV/xvRX6uJ8wVHddUuWvRoMcdVirD+puTULGELg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709638927; c=relaxed/simple; bh=csvhfzFxAJjRZ6Vucqt73nQEpjJgDtYBczC1N+jfb1k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bgKWesNucHgbgHsqhl8C2yPK9kfNSg6rOAd0+wc59fmmvAFSrz0XLYxHCXjfEEw0OexCAFooqsk/UFHJ7ysGo4DAy6cs/IgaeKw39CQoyHURJ2A3st0cNUOSjG0zz4BbrhVuDah966BFh1DbiAbLQDewOKzsYze4faF9KD9e61s= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1709638923; bh=csvhfzFxAJjRZ6Vucqt73nQEpjJgDtYBczC1N+jfb1k=; h=From:To:Cc:Subject:Date:From; b=IFDN19aO142Ieg+dXoRKWji76PmgEA64IycUW2BGpjW9pH6bW+1L9Pu+cbXlYCLz5 OmOrtTNvZE29sQVvlBp4lrgeN7tzFTGavrdL9O5QmrSUSJKaMIs2/PffhsBUv3ePSe re6l0zsjhSU9KkdAVNhVzPYrpdfjzQK9qjL6s9Ec= Received: from stargazer.. (unknown [IPv6:240e:358:115a:2100:dc73:854d:832e:6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 919CA675B0; Tue, 5 Mar 2024 06:41:58 -0500 (EST) From: Xi Ruoyao To: gcc-patches@gcc.gnu.org Cc: Jeff Law , chenglulu , i@xen0n.name, xuchenghua@loongson.cn, YunQiang Su , Xi Ruoyao Subject: [PATCH v3] testsuite: Add a test case for negating FP vectors containing zeros Date: Tue, 5 Mar 2024 19:40:52 +0800 Message-ID: <20240305114148.366553-1-xry111@xry111.site> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, LIKELY_SPAM_FROM, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Recently I've fixed two wrong FP vector negate implementation which caused wrong sign bits in zeros in targets (r14-8786 and r14-8801). To prevent a similar issue from happening again, add a test case. Tested on x86_64 (with SSE2, AVX, AVX2, and AVX512F), AArch64, MIPS (with MSA), LoongArch (with LSX and LASX). gcc/testsuite: * gcc.dg/vect/vect-neg-zero.c: New test. --- - v1 -> v2: Remove { dg-do run } which may cause SIGILL. - v2 -> v3: Add -fno-associative-math to fix an excessive warning on arm. Ok for trunk? gcc/testsuite/gcc.dg/vect/vect-neg-zero.c | 38 +++++++++++++++++++++++ 1 file changed, 38 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/vect/vect-neg-zero.c diff --git a/gcc/testsuite/gcc.dg/vect/vect-neg-zero.c b/gcc/testsuite/gcc.dg/vect/vect-neg-zero.c new file mode 100644 index 00000000000..21fa00cfa15 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/vect-neg-zero.c @@ -0,0 +1,38 @@ +/* { dg-add-options ieee } */ +/* { dg-additional-options "-fno-associative-math -fsigned-zeros" } */ + +double x[4] = {-0.0, 0.0, -0.0, 0.0}; +float y[8] = {-0.0, 0.0, -0.0, 0.0, -0.0, -0.0, 0.0, 0.0}; + +static __attribute__ ((always_inline)) inline void +test (int factor) +{ + double a[4]; + float b[8]; + + asm ("" ::: "memory"); + + for (int i = 0; i < 2 * factor; i++) + a[i] = -x[i]; + + for (int i = 0; i < 4 * factor; i++) + b[i] = -y[i]; + +#pragma GCC novector + for (int i = 0; i < 2 * factor; i++) + if (__builtin_signbit (a[i]) == __builtin_signbit (x[i])) + __builtin_abort (); + +#pragma GCC novector + for (int i = 0; i < 4 * factor; i++) + if (__builtin_signbit (b[i]) == __builtin_signbit (y[i])) + __builtin_abort (); +} + +int +main (void) +{ + test (1); + test (2); + return 0; +}