| Message ID | 20240219213333.90226-1-quic_apinski@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Committed] analyzer: Fix maybe_undo_optimize_bit_field_compare vs non-scalar types [PR113983] | expand |
On Mon, Feb 19, 2024 at 01:33:33PM -0800, Andrew Pinski wrote:
> * gcc.dg/analyzer/torture/vector-extract-1.c: New test.
The testcase fails on i686-linux with
.../gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c:11:1: warning: MMX vector return without MMX enabled changes the ABI [-Wpsabi]
Added -Wno-psabi to silence the warning.
Tested with
make check-gcc RUNTESTFLAGS='--target_board=unix\{-m32/-march=i686,-m64\} analyzer-torture.exp=vector-extract-1.c'
and committed to trunk as obvious.
2024-02-20 Jakub Jelinek <jakub@redhat.com>
PR analyzer/113983
* gcc.dg/analyzer/torture/vector-extract-1.c: Add -Wno-psabi as
dg-additional-options.
--- gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c.jj 2024-02-20 10:26:02.459258772 +0100
+++ gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c 2024-02-20 10:30:39.157416005 +0100
@@ -1,4 +1,5 @@
/* PR analyzer/113983 */
+/* { dg-additional-options "-Wno-psabi" } */
/* maybe_undo_optimize_bit_field_compare used to ICE on this
because it was not checking for only integer types. */
Jakub
diff --git a/gcc/analyzer/region-model-manager.cc b/gcc/analyzer/region-model-manager.cc index 62f808a81c2..21e13b48025 100644 --- a/gcc/analyzer/region-model-manager.cc +++ b/gcc/analyzer/region-model-manager.cc @@ -602,6 +602,9 @@ maybe_undo_optimize_bit_field_compare (tree type, tree cst, const svalue *arg1) { + if (!INTEGRAL_TYPE_P (type)) + return NULL; + const binding_map &map = compound_sval->get_map (); unsigned HOST_WIDE_INT mask = TREE_INT_CST_LOW (cst); /* If "mask" is a contiguous range of set bits, see if the diff --git a/gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c b/gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c new file mode 100644 index 00000000000..5b878e6e4e2 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c @@ -0,0 +1,14 @@ +/* PR analyzer/113983 */ + +/* maybe_undo_optimize_bit_field_compare used to ICE on this + because it was not checking for only integer types. */ + +typedef int __attribute__((__vector_size__(8))) V; +int i; + +V +foo(void) +{ + V v = (V){}; + return (0, 0) * (i & v); +}
After r14-6419-g4eaaf7f5a378e8, maybe_undo_optimize_bit_field_compare would ICE on vector CST but this function really should be checking if we had integer types so reject non-integral types early on (like it was doing for non-char type before r14-6419-g4eaaf7f5a378e8). Committed as obvious after build and tested for aarch64-linux-gnu with no regressions. PR analyzer/113983 gcc/analyzer/ChangeLog: * region-model-manager.cc (maybe_undo_optimize_bit_field_compare): Reject non integral types. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/torture/vector-extract-1.c: New test. Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com> --- gcc/analyzer/region-model-manager.cc | 3 +++ .../gcc.dg/analyzer/torture/vector-extract-1.c | 14 ++++++++++++++ 2 files changed, 17 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/analyzer/torture/vector-extract-1.c