| Message ID | 20240213214530.4177961-1-quic_apinski@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | vect/testsuite: Fix vect-simd-clone-1[02].c when dg-do default is compile [PR113899] | expand |
On Tue, Feb 13, 2024 at 10:46 PM Andrew Pinski <quic_apinski@quicinc.com> wrote: > > The vect testsuite will chose the dg-do default based on if it knows the > running target does not support running with the vector extensions enabled > (for easy of testing). The problem is when it is decided the default is compile > instead of run, dg-additional-sources does not work. So the fix is to set > dg-do on these two testcases to run explicitly. > > OK? Tested on x86_64 with a hack to check_vect_support_and_set_flags to set the dg-default > to compile. OK > gcc/testsuite/ChangeLog: > > PR testsuite/113899 > * gcc.dg/vect/vect-simd-clone-10.c: Add `dg-do run` > * gcc.dg/vect/vect-simd-clone-12.c: Likewise. > > Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com> > --- > gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c | 2 ++ > gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c > index ed63ff59cc0..009c849b7e7 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c > @@ -1,3 +1,5 @@ > +/* Since this uses dg-additional-sources, need to specify `dg-do run` instead of the default. */ > +/* { dg-do run } */ > /* { dg-require-effective-target vect_simd_clones } */ > /* { dg-additional-options "-fopenmp-simd" } */ > /* { dg-additional-options "-mavx" { target avx_runtime } } */ > diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c > index c44471e35bc..4699a3f3c80 100644 > --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c > +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c > @@ -1,3 +1,5 @@ > +/* Since this uses dg-additional-sources, need to specify `dg-do run` instead of the default. */ > +/* { dg-do run } */ > /* { dg-require-effective-target vect_simd_clones } */ > /* { dg-additional-options "-fopenmp-simd" } */ > /* { dg-additional-options "-mavx" { target avx_runtime } } */ > -- > 2.43.0 >
diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c index ed63ff59cc0..009c849b7e7 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c @@ -1,3 +1,5 @@ +/* Since this uses dg-additional-sources, need to specify `dg-do run` instead of the default. */ +/* { dg-do run } */ /* { dg-require-effective-target vect_simd_clones } */ /* { dg-additional-options "-fopenmp-simd" } */ /* { dg-additional-options "-mavx" { target avx_runtime } } */ diff --git a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c index c44471e35bc..4699a3f3c80 100644 --- a/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c +++ b/gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c @@ -1,3 +1,5 @@ +/* Since this uses dg-additional-sources, need to specify `dg-do run` instead of the default. */ +/* { dg-do run } */ /* { dg-require-effective-target vect_simd_clones } */ /* { dg-additional-options "-fopenmp-simd" } */ /* { dg-additional-options "-mavx" { target avx_runtime } } */
The vect testsuite will chose the dg-do default based on if it knows the running target does not support running with the vector extensions enabled (for easy of testing). The problem is when it is decided the default is compile instead of run, dg-additional-sources does not work. So the fix is to set dg-do on these two testcases to run explicitly. OK? Tested on x86_64 with a hack to check_vect_support_and_set_flags to set the dg-default to compile. gcc/testsuite/ChangeLog: PR testsuite/113899 * gcc.dg/vect/vect-simd-clone-10.c: Add `dg-do run` * gcc.dg/vect/vect-simd-clone-12.c: Likewise. Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com> --- gcc/testsuite/gcc.dg/vect/vect-simd-clone-10.c | 2 ++ gcc/testsuite/gcc.dg/vect/vect-simd-clone-12.c | 2 ++ 2 files changed, 4 insertions(+)