From patchwork Tue Feb 13 10:44:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1898169 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jZ+r8s5k; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w0EY5pSa; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=jZ+r8s5k; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w0EY5pSa; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TYydr1Vc3z20RF for ; Tue, 13 Feb 2024 21:45:19 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 20C523858284 for ; Tue, 13 Feb 2024 10:45:17 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id B528B3858C3A for ; Tue, 13 Feb 2024 10:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B528B3858C3A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B528B3858C3A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707821100; cv=none; b=bKvMNy+tV3tTmfzPSfjn+Ru7MAjkquIa5S+NhZCiinIgJjW1ndMnhgehxj4FvPZxtNmXxUEEUHkKBQRXqOupFyyruA3PkSO5HCpVo8z7jN4q6RK7mJYx60AKbrlAyPiVTtt/gIvW11nyz+J4FwRv9ff517mtWqbbeFdqLsuOYLQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707821100; c=relaxed/simple; bh=3zb6Fm4mEVaxJnDyYntnYTeA64UbxsaGUdLuqDV9Xi0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=wrvqwsnG4hYIaZJrsOyFBKTTuJ7faR/vWcvJTtK785auef17HgPBg/aBwKYT1jrs3MbP8PZJdFgulrPYgUZvtY++IF4XV0iE7reG0Ho8bauXpdXn9YDDBUbaRXt0OzO4ANbNHN6kDhrcp0NmKp35aJdf4+Yc63iBFSwpIi3AViM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AFCF91FC81 for ; Tue, 13 Feb 2024 10:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707821097; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; b=jZ+r8s5kXAVHQSmxZfEQi7auVMdemAXb4FY+H1Zd58tE1Yv4yYMzQGGc3Hl481OCYeYxVO FVaD54fYEsPoJmPygm4iQ5vmmHaTs71S2ntNv5yhLBc6Tr7cdlsMteVrNf+3CIszHh+eG1 iOXDm/7pzVjeqrQvPz7HFMMp3+EF3zE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707821097; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; b=w0EY5pSabe5NGUZCq2DXu5emUFCPaReRAw2Mx/n3PGrdCFL/8To/G5j7/w6TC1uAMQEDgc k4QuRjlaPiKCWnBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707821097; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; b=jZ+r8s5kXAVHQSmxZfEQi7auVMdemAXb4FY+H1Zd58tE1Yv4yYMzQGGc3Hl481OCYeYxVO FVaD54fYEsPoJmPygm4iQ5vmmHaTs71S2ntNv5yhLBc6Tr7cdlsMteVrNf+3CIszHh+eG1 iOXDm/7pzVjeqrQvPz7HFMMp3+EF3zE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707821097; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=H1CyOubF4A08XsSL3wNGiXhyaG8X4jmzN6lGRI9GD+s=; b=w0EY5pSabe5NGUZCq2DXu5emUFCPaReRAw2Mx/n3PGrdCFL/8To/G5j7/w6TC1uAMQEDgc k4QuRjlaPiKCWnBw== Date: Tue, 13 Feb 2024 11:44:57 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/113898 - ICE with sanity checking for VN ref adjustment MIME-Version: 1.0 Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-0.60 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Level: X-Spam-Score: -0.60 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240213104517.20C523858284@sourceware.org> The following fixes a missing add to the accumulated offset when adjusting an ARRAY_REF op for value-ranges applied to by get_ref_base_and_extent. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/113898 * tree-ssa-sccvn.cc (copy_reference_ops_from_ref): Add missing accumulated off adjustment. * gcc.dg/torture/pr113898.c: New testcase. --- gcc/testsuite/gcc.dg/torture/pr113898.c | 16 ++++++++++++++++ gcc/tree-ssa-sccvn.cc | 1 + 2 files changed, 17 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/torture/pr113898.c diff --git a/gcc/testsuite/gcc.dg/torture/pr113898.c b/gcc/testsuite/gcc.dg/torture/pr113898.c new file mode 100644 index 00000000000..6832a345271 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr113898.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ + +int a, d; +unsigned **b; +long c, f; +long e[2][1]; +void g() { + int h = 0; + for (; h < 2; h++) { + e[h][d + **b + a] = c; + if (f) + for (;;) + ; + } +} +void main() {} diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc index 2823573b656..5a49390a79c 100644 --- a/gcc/tree-ssa-sccvn.cc +++ b/gcc/tree-ssa-sccvn.cc @@ -1126,6 +1126,7 @@ copy_reference_ops_from_ref (tree ref, vec *result) op.op0 = wide_int_to_tree (TREE_TYPE (op.op0), wi::to_poly_wide (op.op1) + idx); op.off = idx * elsz; + off += op.off; } else {