From patchwork Wed Nov 8 15:03:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1861641 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=GMcTwCtu; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=cR8vRUlu; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SQSyr3kQ0z1yRF for ; Thu, 9 Nov 2023 02:03:48 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 793963861858 for ; Wed, 8 Nov 2023 15:03:46 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id F1CD0385C6FA for ; Wed, 8 Nov 2023 15:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F1CD0385C6FA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F1CD0385C6FA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699455816; cv=none; b=ejyywihmGdwsIEVnF68EwNcT0dcpr8+MnUJVdQmt71xElZyY+VKPsyXHg//iw8XXIgfViHrObukJ7L7Dv1N4AMCDaH/GUqdcuTi5GWNQa3vTQXmcg4t+LiCPXIbl7VOBjKzXhnzH0i+dqBOrLK6irnfh0gFx40JXII+6kfyQE4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699455816; c=relaxed/simple; bh=YkOIZpW7HIoE1d9FtKriCZUPoh+5Y+G26XrRYiFxIog=; h=DKIM-Signature:DKIM-Signature:Date:From:To:Subject:MIME-Version: Message-Id; b=tAUCWek83woQO76mjywLi6wDRN3l5yAsxJqm48wh011i1o1qeXM53xxvlASnjhy3ZYK4ouPLLTpBIE4jthkKOLodqB/CTOMayecLgEQpECIuIMmUhWNfRjICMCfDsL3scDnDJHDqQtRRVbTV3Na7fMx6bZHjT/9POTLMb5QNK2E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 103921F45A for ; Wed, 8 Nov 2023 15:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699455805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=5fcVoYXT3jz7r4kCzXMqZfV9S1DWzEK0UaNBZwI8Xno=; b=GMcTwCtupvnQbQvzwEwsN9tvdoLV03+D1KvqoK6+JJ2/kSu2WJXk2XDcwY58aXINvccXxh KeA5gpZFiX8UMFGHC3+6L01M5FdBj/k9hIMzTW4jLuKbj0gQkoR3v0JuKpwzVs6E78heEF /8PmfeZl+TSqMDtB5TLJAOBDKA9W3AU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699455805; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=5fcVoYXT3jz7r4kCzXMqZfV9S1DWzEK0UaNBZwI8Xno=; b=cR8vRUluSKtXhLiLAlY41iCGe6Us3ksak7PsYNnIkzRw2reMFCSKgKB2PThnPlUIgaH673 mKj4a/xTaDw55MCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E6D3A133F5 for ; Wed, 8 Nov 2023 15:03:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5XAwNzyjS2UVeAAAMHmgww (envelope-from ) for ; Wed, 08 Nov 2023 15:03:24 +0000 Date: Wed, 8 Nov 2023 16:03:24 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH 3/4] Fix SLP of emulated gathers MIME-Version: 1.0 Message-Id: <20231108150324.E6D3A133F5@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The following fixes an error in the SLP of emulated gathers, discovered by x86 specific tests when enabling single-lane SLP. Bootstrap and regtest running on x86_64-unknown-linux-gnu. * tree-vect-stmts.cc (vectorizable_load): Adjust offset vector gathering for SLP of emulated gathers. --- gcc/tree-vect-stmts.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 61e23b29516..913a4fb08ed 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -11163,7 +11163,7 @@ vectorizable_load (vec_info *vinfo, than the data vector for now. */ unsigned HOST_WIDE_INT factor = const_offset_nunits / const_nunits; - vec_offset = vec_offsets[j / factor]; + vec_offset = vec_offsets[(vec_num * j + i) / factor]; unsigned elt_offset = (j % factor) * const_nunits; tree idx_type = TREE_TYPE (TREE_TYPE (vec_offset)); tree scale = size_int (gs_info.scale);