From patchwork Tue Aug 22 10:51:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "juzhe.zhong@rivai.ai" X-Patchwork-Id: 1824096 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RVR4P6C9cz1yNm for ; Tue, 22 Aug 2023 20:52:05 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B47CE38319D1 for ; Tue, 22 Aug 2023 10:52:03 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24]) by sourceware.org (Postfix) with ESMTPS id 17B763858D28 for ; Tue, 22 Aug 2023 10:51:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17B763858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp64t1692701500tkuf6zru Received: from rios-cad121.hadoop.rioslab.org ( [58.60.1.7]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 22 Aug 2023 18:51:39 +0800 (CST) X-QQ-SSF: 01400000000000G0V000000A0000000 X-QQ-FEAT: dFVR8TEWHmuQtyJ+i6xXMCaktL7pGsgAiNsJRpa0dGEO2VpX/YHtkUyQDnh4g RFdLB6Csu10tcTwdMYRJZSrDgZmsyhOQ+GoTCYoCmNc9ZXS6uDNsAj9BhKX8bw2smuE2Y8k jijQ/3OpJZ7Mny/06mhL8hoxzSWFEaXp94p09vJXoIkbETPrFTwfycL7mxpUzYe/MOgyXOW xwhkD4B7mwl196JcC5QAb064aKxHF5Yvz+dtshF3tcBAsI7+tPxYv5O8bbXTAEYH8fy5MRb 91Eh/KaJDAgeDzlCOI/uA6A8UJc3Ql3yD5yIZ5AXR5n7hBrTL92i/uIwpakpTPGRo3gHNQO HSQ60fsA33GIbHrj3R6k4NGmNQfpxno3yDeosq3ZzD8UZlZ3ky+/6TFyFBr7RPBIbWa1fq5 oME+L2sdmrE= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 6901124741957320780 From: Juzhe-Zhong To: gcc-patches@gcc.gnu.org Cc: richard.sandiford@arm.com, rguenther@suse.de, Juzhe-Zhong Subject: [PATCH] VECT: Add LEN_FOLD_EXTRACT_LAST pattern Date: Tue, 22 Aug 2023 18:51:37 +0800 Message-Id: <20230822105137.1308817-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi, Richard and Richi. This is the last autovec pattern I want to add for RVV (length loop control). This patch is supposed to handled this following case: int __attribute__ ((noinline, noclone)) condition_reduction (int *a, int min_v, int n) { int last = 66; /* High start value. */ for (int i = 0; i < n; i++) if (a[i] < min_v) last = i; return last; } ARM SVE IR: ... mask__7.11_39 = vect__4.10_37 < vect_cst__38; _40 = loop_mask_36 & mask__7.11_39; last_5 = .FOLD_EXTRACT_LAST (last_15, _40, vect_vec_iv_.7_32); ... RVV IR, we want to see: ... loop_len = SELECT_VL mask__7.11_39 = vect__4.10_37 < vect_cst__38; last_5 = .LEN_FOLD_EXTRACT_LAST (last_15, _40, vect_vec_iv_.7_32, loop_len, bias); ... gcc/ChangeLog: * doc/md.texi: Add LEN_FOLD_EXTRACT_LAST pattern. * internal-fn.cc (fold_len_extract_direct): Ditto. (expand_fold_len_extract_optab_fn): Ditto. (direct_fold_len_extract_optab_supported_p): Ditto. * internal-fn.def (LEN_FOLD_EXTRACT_LAST): Ditto. --- gcc/doc/md.texi | 6 ++++++ gcc/internal-fn.cc | 5 +++++ gcc/internal-fn.def | 3 +++ 3 files changed, 14 insertions(+) diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi index 89562fdb43c..24453693d89 100644 --- a/gcc/doc/md.texi +++ b/gcc/doc/md.texi @@ -5636,6 +5636,12 @@ has mode @var{m} and operands 0 and 1 have the mode appropriate for one element of @var{m}. Operand 2 has the usual mask mode for vectors of mode @var{m}; see @code{TARGET_VECTORIZE_GET_MASK_MODE}. +@cindex @code{len_fold_extract_last_@var{m}} instruction pattern +@item @code{len_fold_extract_last_@var{m}} +Like @samp{fold_extract_last_@var{m}}, but takes an extra length operand as +operand 4 and an extra bias operand as operand 5. The last associated element +is extracted should have the index i < len (operand 4) + bias (operand 5). + @cindex @code{fold_left_plus_@var{m}} instruction pattern @item @code{fold_left_plus_@var{m}} Take scalar operand 1 and successively add each element from vector diff --git a/gcc/internal-fn.cc b/gcc/internal-fn.cc index 314f63b614b..4138cc31d7e 100644 --- a/gcc/internal-fn.cc +++ b/gcc/internal-fn.cc @@ -188,6 +188,7 @@ init_internal_fns () #define cond_len_ternary_direct { 1, 1, true } #define while_direct { 0, 2, false } #define fold_extract_direct { 2, 2, false } +#define fold_len_extract_direct { 2, 2, false } #define fold_left_direct { 1, 1, false } #define mask_fold_left_direct { 1, 1, false } #define mask_len_fold_left_direct { 1, 1, false } @@ -3863,6 +3864,9 @@ expand_convert_optab_fn (internal_fn fn, gcall *stmt, convert_optab optab, #define expand_fold_extract_optab_fn(FN, STMT, OPTAB) \ expand_direct_optab_fn (FN, STMT, OPTAB, 3) +#define expand_fold_len_extract_optab_fn(FN, STMT, OPTAB) \ + expand_direct_optab_fn (FN, STMT, OPTAB, 5) + #define expand_fold_left_optab_fn(FN, STMT, OPTAB) \ expand_direct_optab_fn (FN, STMT, OPTAB, 2) @@ -3980,6 +3984,7 @@ multi_vector_optab_supported_p (convert_optab optab, tree_pair types, #define direct_mask_len_store_optab_supported_p convert_optab_supported_p #define direct_while_optab_supported_p convert_optab_supported_p #define direct_fold_extract_optab_supported_p direct_optab_supported_p +#define direct_fold_len_extract_optab_supported_p direct_optab_supported_p #define direct_fold_left_optab_supported_p direct_optab_supported_p #define direct_mask_fold_left_optab_supported_p direct_optab_supported_p #define direct_mask_len_fold_left_optab_supported_p direct_optab_supported_p diff --git a/gcc/internal-fn.def b/gcc/internal-fn.def index 594f7881511..d09403c0a91 100644 --- a/gcc/internal-fn.def +++ b/gcc/internal-fn.def @@ -312,6 +312,9 @@ DEF_INTERNAL_OPTAB_FN (EXTRACT_LAST, ECF_CONST | ECF_NOTHROW, DEF_INTERNAL_OPTAB_FN (FOLD_EXTRACT_LAST, ECF_CONST | ECF_NOTHROW, fold_extract_last, fold_extract) +DEF_INTERNAL_OPTAB_FN (LEN_FOLD_EXTRACT_LAST, ECF_CONST | ECF_NOTHROW, + len_fold_extract_last, fold_len_extract) + DEF_INTERNAL_OPTAB_FN (FOLD_LEFT_PLUS, ECF_CONST | ECF_NOTHROW, fold_left_plus, fold_left)