From patchwork Mon Jul 3 07:22:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1802526 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=sDEGurJQ; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qvcq15ZvQz20b9 for ; Mon, 3 Jul 2023 17:23:41 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BF7953858023 for ; Mon, 3 Jul 2023 07:23:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BF7953858023 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1688369019; bh=+lDxwDeKGdbgwLyI5qbciRRq9T9ZwNa1VBpPwpFDaGI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=sDEGurJQg/B/qoqD1MvfZO55mxs1F2TFlIBm1A9zeUrg2ElFrXjIfL7aDWWgiAKFG UY3i2ZwJMxbGDYB9/wTWfpg3ooeIaIlimgotGyQ72BOnONnP2YGBPkQI5JVQemZVIg raEpZgyB5zUhNOd10dc3W9NF24Cul6nZQJeltHdM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id CB0AA3857C71 for ; Mon, 3 Jul 2023 07:22:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB0AA3857C71 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id C1F64218F6 for ; Mon, 3 Jul 2023 07:22:36 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B89082C141 for ; Mon, 3 Jul 2023 07:22:36 +0000 (UTC) Date: Mon, 3 Jul 2023 07:22:36 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/110506 - ICE in pattern recog with TYPE_PRECISION User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230703072339.BF7953858023@sourceware.org> The following re-orders checks to make sure we check TYPE_PRECISION on an integral type. Bootstrap and regtest running on x86_6-unknown-linux-gnu. PR tree-optimization/110506 * tree-vect-patterns.cc (vect_recog_rotate_pattern): Re-order TYPE_PRECISION access with INTEGRAL_TYPE_P check. * gcc.dg/pr110506-2.c: New testcase. --- gcc/testsuite/gcc.dg/pr110506-2.c | 18 ++++++++++++++++++ gcc/tree-vect-patterns.cc | 4 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/pr110506-2.c diff --git a/gcc/testsuite/gcc.dg/pr110506-2.c b/gcc/testsuite/gcc.dg/pr110506-2.c new file mode 100644 index 00000000000..aabca0fa156 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr110506-2.c @@ -0,0 +1,18 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +typedef unsigned uint32_t; +typedef uint32_t uint32x4 __attribute__((vector_size(16))); +typedef struct { + uint32x4 b, d; +} prng_t; +prng_t prng_rand_128_r_x; +int main_flags; +int main() { + uint32_t ref_crc[] = {7, 3}; + uint32x4 e = (prng_rand_128_r_x.b << 27) + (prng_rand_128_r_x.b >> 32 - 27); + prng_rand_128_r_x.d = e; + if (ref_crc[main_flags]) + __builtin_abort (); + return 0; +} diff --git a/gcc/tree-vect-patterns.cc b/gcc/tree-vect-patterns.cc index 25f7f8e1e44..de20e9d59cb 100644 --- a/gcc/tree-vect-patterns.cc +++ b/gcc/tree-vect-patterns.cc @@ -3726,8 +3726,8 @@ vect_recog_rotate_pattern (vec_info *vinfo, return NULL; if (TREE_CODE (oprnd0) != SSA_NAME - || TYPE_PRECISION (TREE_TYPE (lhs)) != TYPE_PRECISION (type) - || !INTEGRAL_TYPE_P (type)) + || !INTEGRAL_TYPE_P (type) + || TYPE_PRECISION (TREE_TYPE (lhs)) != TYPE_PRECISION (type)) return NULL; stmt_vec_info def_stmt_info;