From patchwork Mon May 15 09:42:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 1781251 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=NHlEZFjX; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QKZHV6Tbtz20dX for ; Mon, 15 May 2023 19:45:42 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D53D5382A2CF for ; Mon, 15 May 2023 09:45:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D53D5382A2CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684143940; bh=seuHYY+fxi/SjOn15ifv3xzyHreKcFKwWenXUr3zKkk=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=NHlEZFjXXUQHKvJ28n31R6cX5UHQ3YqKTPhu1DJJRafrudev4NZQMVJ7iRHqIWVf4 2onXLFbxhS4W8uCOmDY+BvipONARgE+Xn8M0KOFItnOEh07MmJUA+ot7cYChfK4y8q 7BWB4sAspSOgdEavJqfiIE53e38XFkVw8mu5mv4M= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 771143854162 for ; Mon, 15 May 2023 09:42:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 771143854162 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-3f41dceb9d1so95721465e9.1 for ; Mon, 15 May 2023 02:42:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684143777; x=1686735777; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=seuHYY+fxi/SjOn15ifv3xzyHreKcFKwWenXUr3zKkk=; b=aCbHkoMRAC5w67D7DEr+tVNxucAPME1jLVoT1Ya5YmWnvpJAPp59liXnnLLB5QFMvR S4Zja9DznzuLLQ4BanIadOCD8AZUf4rKNzkQU8zITm/45waprkYVQKhLQx5JV1vjZP+7 fpPq4AT4nJubV3CFWr96br1E3PCtUJdYjgJgp21w0joFFkX4r+U0xIBxt6WoetV8XL0n VoaPwLq2L8DQJsnMF93ra2Yj3aipODAorNuH+2UKyLGBpBltix8R4jAtcjWSVsYMxRuM OB9OvHPU5yQ/MpqkywxNYa8pZZMcRD99iNloA2/dYapy2Q7hIafFLqC/S6rDuWEtXbEK H6qw== X-Gm-Message-State: AC+VfDwlazRx74IQ4MWPNCTgJ7jKoFa5nj+N5R2yN6wwxTmLQ4PjiHnV GBJh/IYM4lZWUIaadHh7SLg+PkDaztdJq1Gm6RjG6A== X-Google-Smtp-Source: ACHHUZ6nIhdiMFLOBKIdx2Ly7GFnAXf4WoszTB7EplZwkd+109/vrY0eqp3i+/jnHyJqLe09h1+g6Q== X-Received: by 2002:a7b:c855:0:b0:3f4:23e5:5bb0 with SMTP id c21-20020a7bc855000000b003f423e55bb0mr20385845wml.5.1684143777227; Mon, 15 May 2023 02:42:57 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id w22-20020a1cf616000000b003f080b2f9f4sm36280969wmc.27.2023.05.15.02.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 May 2023 02:42:56 -0700 (PDT) To: gcc-patches@gcc.gnu.org Cc: Bob Duff Subject: [COMMITTED] ada: Add Check_Error_Detected before "raise Bad_Attribute" Date: Mon, 15 May 2023 11:42:54 +0200 Message-Id: <20230515094254.1407902-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Marc_Poulhi=C3=A8s_via_Gcc-patches?= From: =?utf-8?q?Marc_Poulhi=C3=A8s?= Reply-To: =?utf-8?q?Marc_Poulhi=C3=A8s?= Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" From: Bob Duff We shouldn't raise Bad_Attribute if there is no error. This patch adds a call to Check_Error_Detected to make sure that's true. (There are other cases where we raise Bad_Attribute; this patch doesn't try to fix them all.) gcc/ada/ * sem_attr.adb (Analyze_Attribute): Add a call to Check_Error_Detected. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_attr.adb | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/ada/sem_attr.adb b/gcc/ada/sem_attr.adb index 77c56aa587b..9de9884069e 100644 --- a/gcc/ada/sem_attr.adb +++ b/gcc/ada/sem_attr.adb @@ -3299,6 +3299,7 @@ package body Sem_Attr is -- Check for missing/bad expression (result of previous error) if No (E1) or else Etype (E1) = Any_Type then + Check_Error_Detected; raise Bad_Attribute; end if; end if;