From patchwork Tue Apr 18 08:52:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 1770018 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=oDvAMJV+; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q0yQ93wxJz1yZy for ; Tue, 18 Apr 2023 18:53:52 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B55773858D1E for ; Tue, 18 Apr 2023 08:53:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B55773858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1681808030; bh=ocDmXKG6gH3aoAnpwtihile2c/jadVZdM3PdOd9UcU8=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=oDvAMJV+F/za2/LNs7H9zfpFbLetcHX57xYXPPZN0w1G3mM2gvHbk3TErw1ygNvE8 skZl+LObtDcKttSvunwT+ySl1Pa0sv/qCP0SqFeIIpLJuj0brshbhtkBwqoj8/BygI oCIREyO5q/jD0u6IQ8c3U5rcKI3eYp4LlLd+ccA4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0B6DE3858D1E for ; Tue, 18 Apr 2023 08:53:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B6DE3858D1E Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-288-y-PPAR_MPk2BIsMtbfb8nw-1; Tue, 18 Apr 2023 04:53:30 -0400 X-MC-Unique: y-PPAR_MPk2BIsMtbfb8nw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E31051C12985 for ; Tue, 18 Apr 2023 08:53:29 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.194.164]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B7C7483EC4; Tue, 18 Apr 2023 08:53:29 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 33I8rQMw252174 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 10:53:27 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 33I8rQaG252173; Tue, 18 Apr 2023 10:53:26 +0200 To: GCC patches Cc: Andrew MacLeod , Jakub Jelinek , Aldy Hernandez Subject: [PATCH] Return true from operator== for two identical ranges containing NAN. Date: Tue, 18 Apr 2023 10:52:56 +0200 Message-Id: <20230418085255.252125-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" [Andrew, we talked about this a few months ago. Just making sure we're on the same page so I can push it. Also, a heads-up for Jakub.] The == operator for ranges signifies that two ranges contain the same thing, not that they are ultimately equal. So [2,4] == [2,4], even though one may be a 2 and the other may be a 3. Similarly with two VARYING ranges. There is an oversight in frange::operator== where we are returning false for two identical NANs. This is causing us to never cache NANs in sbr_sparse_bitmap::set_bb_range. --- gcc/value-range.cc | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index ec826c2fe1b..963330eed79 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -629,9 +629,6 @@ frange::operator== (const frange &src) const if (varying_p ()) return types_compatible_p (m_type, src.m_type); - if (known_isnan () || src.known_isnan ()) - return false; - return (real_identical (&m_min, &src.m_min) && real_identical (&m_max, &src.m_max) && m_pos_nan == src.m_pos_nan @@ -3749,13 +3746,6 @@ range_tests_nan () ASSERT_TRUE (r0.maybe_isnan ()); } - // NAN ranges are not equal to each other. - r0.set_nan (float_type_node); - r1 = r0; - ASSERT_FALSE (r0 == r1); - ASSERT_FALSE (r0 == r0); - ASSERT_TRUE (r0 != r0); - // [5,6] U NAN = [5,6] NAN. r0 = frange_float ("5", "6"); r0.clear_nan ();