From patchwork Thu Mar 23 20:35:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Merrill X-Patchwork-Id: 1760565 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=Ppy6Rk46; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PjHDY6pTSz1yXr for ; Fri, 24 Mar 2023 07:36:12 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 15249384F00E for ; Thu, 23 Mar 2023 20:36:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 15249384F00E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1679603770; bh=iRG0GFW4ve530Oyd0ikM8rVAdLjjdcAe+FjXU4WL87c=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Ppy6Rk46EZJNkCvcTrK4yr4iJ6AwSZrtQivo6a/AHpdOuAIu9R2s/rTftnKcO4tNH Aq7I1WdcAbIWrdTYc6DmfIE0TmshaGmrkgCeRwbmfyYQe05dMum+EWx7T6pNgYf+GP vKuXMoEL7YiHH3+ag52fTz3QDXbH/1E/TS9v1oCo= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3A6053858C50 for ; Thu, 23 Mar 2023 20:35:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A6053858C50 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-VH9N7dw9MAeT6Jck7O7EkA-1; Thu, 23 Mar 2023 16:35:18 -0400 X-MC-Unique: VH9N7dw9MAeT6Jck7O7EkA-1 Received: by mail-qv1-f69.google.com with SMTP id a10-20020a0ccdca000000b005d70160fbb0so3275010qvn.21 for ; Thu, 23 Mar 2023 13:35:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679603711; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iRG0GFW4ve530Oyd0ikM8rVAdLjjdcAe+FjXU4WL87c=; b=0xbi9PW/np1L3B0hv2hRBiq0b3j8kK99CJL1ikPucrlYj4oI7EIq1tyGMQ6KHbDaSA EcJrcJfoIN5T18cECAJ9B/A+mC7KwTAez24wHXizihUuyTjaJkfQ7uNq0cAxBvL39ovZ XMCrnQAFRs2pFvHu1+266q1ZrqbZk8vI0w/6Gj14+s35eysPChSbwk91Zw3/50QM3RlR MQI/qolNM4X0/oaFGkWnbC4b1bJ9qMO7JFXTGZ78W0jbSbBVyCyjDejUsfGiz/R0hK1Z pnaD6355x79xzc4z7ale0vN958OfsFcXdp+VzgcoVXGbCoKbGLUeHsCM4JSSmx/nQfKr RQ/A== X-Gm-Message-State: AAQBX9cyJCtvuw7FrgrgpS58bgiSluUx99poAyJ6BBRnUUFEHlbIPAAp WTeqNHCnmR48eDNOVS/2kxPLhWbTlMxIGVSy6OcfE6UO9KwBSNkw2ZWSqTa0jmArF8ypRs/TIvo FUV6KyvV+SA7b3ev9RAt47oERdv2xfIdNF/K4LboM29cQuFjHnEbdxLgab9iiOl5NbFs5dn2CjQ == X-Received: by 2002:a05:6214:27c6:b0:5cd:f9fd:f66a with SMTP id ge6-20020a05621427c600b005cdf9fdf66amr530974qvb.0.1679603710872; Thu, 23 Mar 2023 13:35:10 -0700 (PDT) X-Google-Smtp-Source: AKy350ZrX+75VQVtMHzCzn/OpIZDD/tbHfeNzw5ijJMoD9eDvyssvUIjTYJzC+BimbE+X5xiTnxOBg== X-Received: by 2002:a05:6214:27c6:b0:5cd:f9fd:f66a with SMTP id ge6-20020a05621427c600b005cdf9fdf66amr530927qvb.0.1679603710451; Thu, 23 Mar 2023 13:35:10 -0700 (PDT) Received: from jason.cygnus.com (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id h26-20020ac846da000000b003bfb5fd72a7sm12188273qto.86.2023.03.23.13.35.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 13:35:10 -0700 (PDT) To: gcc-patches@gcc.gnu.org, Jakub Jelinek Subject: [PATCH RFC] c-family: -Wsequence-point and COMPONENT_REF [PR107163] Date: Thu, 23 Mar 2023 16:35:07 -0400 Message-Id: <20230323203507.2960052-1-jason@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jason Merrill via Gcc-patches From: Jason Merrill Reply-To: Jason Merrill Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Tested x86_64-pc-linux-gnu. Jakub, does this make sense to you? Do we have a way of testing for compile-hog regressions? -- 8< -- The patch for PR91415 fixed -Wsequence-point to treat shifts and ARRAY_REF as sequenced in C++17, and COMPONENT_REF as well. But this is unnecessary for COMPONENT_REF, since the RHS is just a FIELD_DECL with no actual evaluation, and in this testcase handling COMPONENT_REF as sequenced blows up fast in a deep inheritance tree. PR c++/107163 gcc/c-family/ChangeLog: * c-common.cc (verify_tree): Don't use sequenced handling for COMPONENT_REF. --- gcc/c-family/c-common.cc | 1 - 1 file changed, 1 deletion(-) base-commit: 4872e46e080c6695dfe1f9dc9db26b4703bc348c diff --git a/gcc/c-family/c-common.cc b/gcc/c-family/c-common.cc index bfb950e56db..a803cf94c68 100644 --- a/gcc/c-family/c-common.cc +++ b/gcc/c-family/c-common.cc @@ -2154,7 +2154,6 @@ verify_tree (tree x, struct tlist **pbefore_sp, struct tlist **pno_sp, case LSHIFT_EXPR: case RSHIFT_EXPR: - case COMPONENT_REF: case ARRAY_REF: if (cxx_dialect >= cxx17) goto sequenced_binary;