diff mbox series

[COMMITTED] Remove assert from set_nonzero_bits.

Message ID 20221004175221.1493497-1-aldyh@redhat.com
State New
Headers show
Series [COMMITTED] Remove assert from set_nonzero_bits. | expand

Commit Message

Aldy Hernandez Oct. 4, 2022, 5:52 p.m. UTC 
The assert removed by this patch was there to keep users from passing
masks of incompatible types.  The self tests are passing host wide
ints down (set_nonzero_bits (-1)), which seem to be 32 bits, whereas
some embedded targets have integer_type_node's of 16-bits.  This is
causing problems in m32c-elf, among others.

I suppose there's no harm in passing a 32-bit mask, because
set_nonzero_bits calls wide_int::from() to convert the mask to the
appropriate type.  So we can remove the assert.

Sorry for the pain Jeff.

gcc/ChangeLog:

	* value-range.cc (irange::set_nonzero_bits): Remove assert.
---
 gcc/value-range.cc | 1 -
 1 file changed, 1 deletion(-)

Comments

Jeff Law Oct. 4, 2022, 6:45 p.m. UTC | #1 
On 10/4/22 11:52, Aldy Hernandez wrote:
> The assert removed by this patch was there to keep users from passing
> masks of incompatible types.  The self tests are passing host wide
> ints down (set_nonzero_bits (-1)), which seem to be 32 bits, whereas
> some embedded targets have integer_type_node's of 16-bits.  This is
> causing problems in m32c-elf, among others.
>
> I suppose there's no harm in passing a 32-bit mask, because
> set_nonzero_bits calls wide_int::from() to convert the mask to the
> appropriate type.  So we can remove the assert.
>
> Sorry for the pain Jeff.
>
> gcc/ChangeLog:
>
> 	* value-range.cc (irange::set_nonzero_bits): Remove assert.

Thanks.  I'll respin everything that failed this AM and see where we are.


jeff
diff mbox series

Patch

diff --git a/gcc/value-range.cc b/gcc/value-range.cc
index afb26a40083..a307559b654 100644
--- a/gcc/value-range.cc
+++ b/gcc/value-range.cc
@@ -2913,7 +2913,6 @@  irange::set_nonzero_bits (const wide_int_ref &bits)
 {
   gcc_checking_assert (!undefined_p ());
   unsigned prec = TYPE_PRECISION (type ());
-  gcc_checking_assert (prec == bits.get_precision ());
 
   // Drop VARYINGs with a nonzero mask to a plain range.
   if (m_kind == VR_VARYING && bits != -1)