| Message ID | 20220927144019.194796-1-torbjorn.svensson@foss.st.com |
|---|---|
| State | New |
| Headers | show |
| Series | testsuite: Skip intrinsics test if arm | expand |
> -----Original Message----- > From: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > Sent: Tuesday, September 27, 2022 3:40 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>; Richard Sandiford > <Richard.Sandiford@arm.com>; Torbjörn SVENSSON > <torbjorn.svensson@foss.st.com>; Yvan ROUX <yvan.roux@foss.st.com> > Subject: [PATCH] testsuite: Skip intrinsics test if arm > > In the test cases, it's clearly written that intrinsics are not > implemented on arm*. A simple xfail does not help since there are > link error and that would cause an UNRESOLVED testcase rather than > XFAIL. > By changing to dg-skip-if, the entire test case is omitted. > Ok. Thanks, Kyrill > gcc/testsuite/ChangeLog: > > * gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Rephrase > to unimplemented. > * gcc.target/aarch64/advsimd-intrinsics/vld1x3.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vld1x4.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vst1x2.c: Replace > dg-xfail-if with dg-skip-if. > * gcc.target/aarch64/advsimd-intrinsics/vst1x3.c: Likewise. > * gcc.target/aarch64/advsimd-intrinsics/vst1x4.c: Likewise. > > Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com> > Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> > --- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c | 2 +- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c | 2 +- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c | 2 +- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c | 2 +- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c | 2 +- > gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > index f933102be47..0c45a2b227b 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > /* { dg-do run } */ > -/* { dg-skip-if "unsupported" { arm*-*-* } } */ > +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ > /* { dg-options "-O3" } */ > > #include <arm_neon.h> > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c > b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c > index b20dec061b5..4174dcd064a 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > /* { dg-do run } */ > -/* { dg-skip-if "unsupported" { arm*-*-* } } */ > +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ > /* { dg-options "-O3" } */ > > #include <arm_neon.h> > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > index e59f845880e..89b289bb21d 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > /* { dg-do run } */ > -/* { dg-skip-if "unsupported" { arm*-*-* } } */ > +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ > /* { dg-options "-O3" } */ > > #include <arm_neon.h> > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c > b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c > index cb13da0caed..6d20a46b8b6 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > -/* { dg-xfail-if "" { arm*-*-* } } */ > /* { dg-do run } */ > +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ > /* { dg-options "-O3" } */ > > #include <arm_neon.h> > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c > b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c > index 3ce272a5007..87eae4d2f35 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > -/* { dg-xfail-if "" { arm*-*-* } } */ > /* { dg-do run } */ > +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ > /* { dg-options "-O3" } */ > > #include <arm_neon.h> > diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c > b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c > index 1f17b5342de..829a18ddac0 100644 > --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c > +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c > @@ -1,6 +1,6 @@ > /* We haven't implemented these intrinsics for arm yet. */ > -/* { dg-xfail-if "" { arm*-*-* } } */ > /* { dg-do run } */ > +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ > /* { dg-options "-O3" } */ > > #include <arm_neon.h> > -- > 2.25.1
diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c index f933102be47..0c45a2b227b 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c @@ -1,6 +1,6 @@ /* We haven't implemented these intrinsics for arm yet. */ /* { dg-do run } */ -/* { dg-skip-if "unsupported" { arm*-*-* } } */ +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ /* { dg-options "-O3" } */ #include <arm_neon.h> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c index b20dec061b5..4174dcd064a 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c @@ -1,6 +1,6 @@ /* We haven't implemented these intrinsics for arm yet. */ /* { dg-do run } */ -/* { dg-skip-if "unsupported" { arm*-*-* } } */ +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ /* { dg-options "-O3" } */ #include <arm_neon.h> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c index e59f845880e..89b289bb21d 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c @@ -1,6 +1,6 @@ /* We haven't implemented these intrinsics for arm yet. */ /* { dg-do run } */ -/* { dg-skip-if "unsupported" { arm*-*-* } } */ +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ /* { dg-options "-O3" } */ #include <arm_neon.h> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c index cb13da0caed..6d20a46b8b6 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c @@ -1,6 +1,6 @@ /* We haven't implemented these intrinsics for arm yet. */ -/* { dg-xfail-if "" { arm*-*-* } } */ /* { dg-do run } */ +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ /* { dg-options "-O3" } */ #include <arm_neon.h> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c index 3ce272a5007..87eae4d2f35 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c @@ -1,6 +1,6 @@ /* We haven't implemented these intrinsics for arm yet. */ -/* { dg-xfail-if "" { arm*-*-* } } */ /* { dg-do run } */ +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ /* { dg-options "-O3" } */ #include <arm_neon.h> diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c index 1f17b5342de..829a18ddac0 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c @@ -1,6 +1,6 @@ /* We haven't implemented these intrinsics for arm yet. */ -/* { dg-xfail-if "" { arm*-*-* } } */ /* { dg-do run } */ +/* { dg-skip-if "unimplemented" { arm*-*-* } } */ /* { dg-options "-O3" } */ #include <arm_neon.h>
In the test cases, it's clearly written that intrinsics are not implemented on arm*. A simple xfail does not help since there are link error and that would cause an UNRESOLVED testcase rather than XFAIL. By changing to dg-skip-if, the entire test case is omitted. gcc/testsuite/ChangeLog: * gcc.target/aarch64/advsimd-intrinsics/vld1x2.c: Rephrase to unimplemented. * gcc.target/aarch64/advsimd-intrinsics/vld1x3.c: Likewise. * gcc.target/aarch64/advsimd-intrinsics/vld1x4.c: Likewise. * gcc.target/aarch64/advsimd-intrinsics/vst1x2.c: Replace dg-xfail-if with dg-skip-if. * gcc.target/aarch64/advsimd-intrinsics/vst1x3.c: Likewise. * gcc.target/aarch64/advsimd-intrinsics/vst1x4.c: Likewise. Co-Authored-By: Yvan ROUX <yvan.roux@foss.st.com> Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com> --- gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x2.c | 2 +- gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x3.c | 2 +- gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vld1x4.c | 2 +- gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x2.c | 2 +- gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x3.c | 2 +- gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vst1x4.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)