| Message ID | 20220304082759.737439-1-rasmus.villemoes@prevas.dk |
|---|---|
| State | New |
| Headers | show |
| Series | libstdc++: vxworks: remove stray <iostream> include | expand |
On Fri, 4 Mar 2022 at 08:28, Rasmus Villemoes wrote: > > There doesn't seem to be any reason for this TU to include > <iostream>, and it causes errors when the resulting libstdc++ is used > on our VxWorks 5.5 target - presumably because now libstdc++ itself > contains an instance of std::ios_base::Init. Which should be mostly > harmless, but apparently isn't, and from a QoI viewpoint should > probably be avoided anyway. 100% agreed, thanks. > --- > libstdc++-v3/config/locale/vxworks/ctype_members.cc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libstdc++-v3/config/locale/vxworks/ctype_members.cc b/libstdc++-v3/config/locale/vxworks/ctype_members.cc > index 82569d075c6..d8ca551078d 100644 > --- a/libstdc++-v3/config/locale/vxworks/ctype_members.cc > +++ b/libstdc++-v3/config/locale/vxworks/ctype_members.cc > @@ -33,7 +33,6 @@ > #include <cstdlib> > #include <cstring> > #include <cstdio> > -#include <iostream> > > namespace std _GLIBCXX_VISIBILITY(default) > { > -- > 2.31.1 >
Good for me, thanks Rasmus. > On 4 Mar 2022, at 09:27, Rasmus Villemoes <rv@rasmusvillemoes.dk> wrote: > > There doesn't seem to be any reason for this TU to include > <iostream>, and it causes errors when the resulting libstdc++ is used > on our VxWorks 5.5 target - presumably because now libstdc++ itself > contains an instance of std::ios_base::Init. Which should be mostly > harmless, but apparently isn't, and from a QoI viewpoint should > probably be avoided anyway. > --- > libstdc++-v3/config/locale/vxworks/ctype_members.cc | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libstdc++-v3/config/locale/vxworks/ctype_members.cc b/libstdc++-v3/config/locale/vxworks/ctype_members.cc > index 82569d075c6..d8ca551078d 100644 > --- a/libstdc++-v3/config/locale/vxworks/ctype_members.cc > +++ b/libstdc++-v3/config/locale/vxworks/ctype_members.cc > @@ -33,7 +33,6 @@ > #include <cstdlib> > #include <cstring> > #include <cstdio> > -#include <iostream> > > namespace std _GLIBCXX_VISIBILITY(default) > { > -- > 2.31.1 >
diff --git a/libstdc++-v3/config/locale/vxworks/ctype_members.cc b/libstdc++-v3/config/locale/vxworks/ctype_members.cc index 82569d075c6..d8ca551078d 100644 --- a/libstdc++-v3/config/locale/vxworks/ctype_members.cc +++ b/libstdc++-v3/config/locale/vxworks/ctype_members.cc @@ -33,7 +33,6 @@ #include <cstdlib> #include <cstring> #include <cstdio> -#include <iostream> namespace std _GLIBCXX_VISIBILITY(default) {