From patchwork Wed Jan 5 11:33:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1575618 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=N9Vznsw/; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JTShX5tc1z9sPC for ; Wed, 5 Jan 2022 22:59:40 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BD844385843B for ; Wed, 5 Jan 2022 11:59:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BD844385843B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1641383977; bh=btyB20rQicGD2pXGWHE3vFSWBM6uvbftI6eVmVpXcYA=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=N9Vznsw/AkrJta72N6Y8B/BypjJEEwyTaOQrxdscTgAU5yuJ0h7pZZjYmfdivIbXK J63DtvOysfdjwBhXLZ1QxOqsD+IFvckirjR/Gk/vKc0XAuNyiJ7HQY8n+wFu5XNhRW nU0c2tlCSb4C+k8bW1vtVI4aiqm13SP28lKcorIY= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id A476B3858001 for ; Wed, 5 Jan 2022 11:33:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A476B3858001 Received: by mail-wr1-x42a.google.com with SMTP id q8so1748923wra.12 for ; Wed, 05 Jan 2022 03:33:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=btyB20rQicGD2pXGWHE3vFSWBM6uvbftI6eVmVpXcYA=; b=w5iHI72nrqenSbe4XqPP9ZjLXu2D1Izmy7m0R2ICv+XPSbb+KYwRucFRMJAS/+88xS YesLp5LUfS/xJTVEh3f8+IBMUSLqJVjU0WL+tifPRtmIJl8gtrVb2gAHcAB3qHg8c1lP H6Yez+qIgejLycOITA37dvxXNNIa9tbmXPgBnflVWD1v/Ee6E5K6zBaFAxTetAnXGNE2 ximY8DA5/47dFHi+q1cUcvIJIGvyMA1r6298W4mNreJOd2H7USScxwQfU3pZ3cZKIbat MDZ1vdYwoTCxHBsW8XZrHgJcUaIzhrfqKDiWSm3n8rTbGNlWBdn8vMAiI7tqCbBRiMrd f1bA== X-Gm-Message-State: AOAM530OXhV7yctAsy8hlmFYQoETzGCv5A87+Rgs/4xbM4wAb0BSDRII kTMLAGMNCHTRibtRIP2HoJ174f+VqqItHQ== X-Google-Smtp-Source: ABdhPJzLP/6K7/6r2mVI74fqRL22k6AnFMtzCDjISXhh3mlzrOoRKpF5nOK7rzkx+3WnLeKyZW2VPw== X-Received: by 2002:a5d:6d06:: with SMTP id e6mr44277715wrq.50.1641382433767; Wed, 05 Jan 2022 03:33:53 -0800 (PST) Received: from adacore.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id k19sm2159780wmo.29.2022.01.05.03.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 03:33:53 -0800 (PST) Date: Wed, 5 Jan 2022 11:33:52 +0000 To: gcc-patches@gcc.gnu.org Subject: [Ada] Use Add_Char_To_Name_Buffer for 1-character strings Message-ID: <20220105113352.GA2715947@adacore.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Pierre-Marie de Rodat via Gcc-patches From: Pierre-Marie de Rodat Reply-To: Pierre-Marie de Rodat Cc: Piotr Trojanek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Adding a single character to name buffer should be (marginally) more efficient with Add_Char_To_Name_Buffer and not Add_Str_To_Name_Buffer. Even if not more efficient, it should be still more readable. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * exp_dbug.adb, sem_dim.adb: Replace Add_Str_To_Name_Buffer with Add_Char_To_Name_Buffer. diff --git a/gcc/ada/exp_dbug.adb b/gcc/ada/exp_dbug.adb --- a/gcc/ada/exp_dbug.adb +++ b/gcc/ada/exp_dbug.adb @@ -172,7 +172,7 @@ package body Exp_Dbug is procedure Add_Real_To_Buffer (U : Ureal) is begin Add_Uint_To_Buffer (Norm_Num (U)); - Add_Str_To_Name_Buffer ("_"); + Add_Char_To_Name_Buffer ('_'); Add_Uint_To_Buffer (Norm_Den (U)); end Add_Real_To_Buffer; @@ -671,7 +671,7 @@ package body Exp_Dbug is Add_Real_To_Buffer (Delta_Value (E)); if Small_Value (E) /= Delta_Value (E) then - Add_Str_To_Name_Buffer ("_"); + Add_Char_To_Name_Buffer ('_'); Add_Real_To_Buffer (Small_Value (E)); end if; @@ -710,7 +710,7 @@ package body Exp_Dbug is if Lo_Encode or Hi_Encode then if Biased then - Add_Str_To_Name_Buffer ("_"); + Add_Char_To_Name_Buffer ('_'); else if Lo_Encode then if Hi_Encode then @@ -1535,7 +1535,7 @@ package body Exp_Dbug is begin Set_Entity_Name (Var); - Add_Str_To_Name_Buffer ("L"); + Add_Char_To_Name_Buffer ('L'); Set_Chars (Var, Name_Enter); end; @@ -1544,7 +1544,7 @@ package body Exp_Dbug is and then Ekind (Scope (Homonym (Ent))) = E_Block then Set_Entity_Name (Ent); - Add_Str_To_Name_Buffer ("B"); + Add_Char_To_Name_Buffer ('B'); Set_Chars (Ent, Name_Enter); end if; end if; diff --git a/gcc/ada/sem_dim.adb b/gcc/ada/sem_dim.adb --- a/gcc/ada/sem_dim.adb +++ b/gcc/ada/sem_dim.adb @@ -2759,7 +2759,7 @@ package body Sem_Dim is -- Insert a blank between the literal and the symbol - Add_Str_To_Name_Buffer (" "); + Add_Char_To_Name_Buffer (' '); Append (Global_Name_Buffer, Symbol_Of (Typ)); Error_Msg_Name_1 := Name_Find;