From patchwork Wed Jan 5 11:33:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Marie de Rodat X-Patchwork-Id: 1575603 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=v+mRgUtK; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JTSQ44pnhz9sCD for ; Wed, 5 Jan 2022 22:47:08 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 35EC03858400 for ; Wed, 5 Jan 2022 11:47:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35EC03858400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1641383226; bh=S078CprGI1UXKl8PbswX8QDflzqw4sJjqCOvcBoQre0=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=v+mRgUtKOe9Oy+3pdSI3gNQVSXLhTs/PWrv61U2KV7pTEDtMJVEScQSq5k5rE/CLf /BzRj66Tt9p+IXxRJLzaNPhXz+DJh8Qoxq9qnnhuFuBkLg1KVXk9TL1VPzYCnxnTZP ZcQlj1Qep8Wam5EbNzxnji6JzdiOn16ZKcfdbSYU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id D99623858425 for ; Wed, 5 Jan 2022 11:33:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D99623858425 Received: by mail-wr1-x42a.google.com with SMTP id d9so82422017wrb.0 for ; Wed, 05 Jan 2022 03:33:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=S078CprGI1UXKl8PbswX8QDflzqw4sJjqCOvcBoQre0=; b=exAYTdCIaXvsqIbAQm1KDTkxlS3C3cBvcQrNIMqig7YppXiP1rL6RN1Z+L5HX4fnbi ut7UKeuF1yGBP6GW7/cxZlkCCDCSAvTlk/rVUGsR97x2DZFFBemT7G32q3tvKQSN3Dqv 2hS3gnwpxtyo969Io4EJ++wmtqvBq2YkwAi8T1ix/8RA2TaA23vSw0nhqb1Cmz0qwDDQ ztNJ0afc2FyCSONkltB0PheWq7jg/A6o/OnJTfbeikVWLwKeAtim8BMwPe+wKeq86hLr lT6olZhiP8hnOwYZMZy6chhsTd9cCYx3KYMn2v3thbqF1v/RwLYsJNDwBafFdVVTRu9t HnkQ== X-Gm-Message-State: AOAM530B8zGZrIqlATN3+xvqOXjRlf5IuuaXSVWihsVWPDZ+opGV20+V C/dN/9zoxHhe+LhpMq0+OXrOkc77kqyEig== X-Google-Smtp-Source: ABdhPJwifVGOcPsKS6aQ+Bfe/jkWU//2+Bf3rRU0p4eC6kc0J+68SnTbyJix7mGMEL+igTpMglaK1Q== X-Received: by 2002:a5d:6d8a:: with SMTP id l10mr46974337wrs.270.1641382416962; Wed, 05 Jan 2022 03:33:36 -0800 (PST) Received: from adacore.com ([45.147.211.82]) by smtp.gmail.com with ESMTPSA id c2sm45489761wri.50.2022.01.05.03.33.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 03:33:36 -0800 (PST) Date: Wed, 5 Jan 2022 11:33:35 +0000 To: gcc-patches@gcc.gnu.org Subject: [Ada] Remove unnecessary check for missing parameter specifications Message-ID: <20220105113335.GA2714243@adacore.com> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Pierre-Marie de Rodat via Gcc-patches From: Pierre-Marie de Rodat Reply-To: Pierre-Marie de Rodat Cc: Piotr Trojanek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" List iteration with First/Present/Next is safe even for No_List. This safety is intentional and we rely on it in many places. Code cleanup; semantics is unaffected. Tested on x86_64-pc-linux-gnu, committed on trunk gcc/ada/ * exp_disp.adb (Gen_Parameters_Profile): Remove redundant guard. diff --git a/gcc/ada/exp_disp.adb b/gcc/ada/exp_disp.adb --- a/gcc/ada/exp_disp.adb +++ b/gcc/ada/exp_disp.adb @@ -8065,19 +8065,17 @@ package body Exp_Disp is Out_Present => True, Parameter_Type => New_Occurrence_Of (Typ, Loc))); - if Present (Parameter_Specifications (Parent (E))) then - P := First (Parameter_Specifications (Parent (E))); - while Present (P) loop - Append_To (Parms, - Make_Parameter_Specification (Loc, - Defining_Identifier => - Make_Defining_Identifier (Loc, - Chars => Chars (Defining_Identifier (P))), - Parameter_Type => New_Copy_Tree (Parameter_Type (P)), - Expression => New_Copy_Tree (Expression (P)))); - Next (P); - end loop; - end if; + P := First (Parameter_Specifications (Parent (E))); + while Present (P) loop + Append_To (Parms, + Make_Parameter_Specification (Loc, + Defining_Identifier => + Make_Defining_Identifier (Loc, + Chars => Chars (Defining_Identifier (P))), + Parameter_Type => New_Copy_Tree (Parameter_Type (P)), + Expression => New_Copy_Tree (Expression (P)))); + Next (P); + end loop; return Parms; end Gen_Parameters_Profile;